The Aether

The Aether

35M Downloads

Bug: ItemUseConvertEvent does not function correctly

Zepalesque opened this issue ยท 1 comments

commented

What Feature Types Apply to This Bug?

Block, Item, System

Other Type

No response

What Type of Bug Is This?

Unexpected Behavior

Forge Version

45.0.64

The Aether Version

70a6977

Is This Bug a Conflict With Another Mod?

No response

Client Log

No response

Crash Report (if applicable)

No response

Steps to Reproduce

1: Open Minecraft in the debugger
2: Put a breakpoint in ItemUseConvertEvent
3: Use Ambrosium or a Swet Ball on a block that it does not convert
4: Observe the value of newBlockState in the debugger
5: Attempt the same with a Swet ball on something it can work on, like Aether Dirt and observe the newBlockState value again

What You Expect To Happen

The event would not fire the first time, and the second time, it would have the correct newBlockState value

What Actually Happened

For the first one, the event fired regardless of the fact that it is an invalid recipe target. It also used aether:enchanted_aether_grass for the newBlockstate when using ambrosium and minecraft:crimson_nylium when using a swet ball.

For the second test of a Swet Ball on Aether Dirt, it properly fired the event like it should, but the newBlockState value showed up as minecraft:crimson_nylium for some reason.

Additional Details

I would fix this in my pull request, but I'm not sure what's wrong whatsoever, the code looks fine to me. It also goes a bit outside my knowledge unfortunately.

Please Read and Confirm The Following

  • I have confirmed this bug can be replicated without the use of Optifine.
  • I have confirmed this bug is on the most recently supported version of Minecraft.
  • I have confirmed the details provided in this report are concise as possible and does not contained vague information (ie. Versions are properly recorded, answers to questions are clear).
  • I have confirmed this issue is unique and has not been reported already.
  • If playing on a modpack, I have reported this issue to their issue tracker already.
commented

Oh right, another thing that I forgot to mention is that the event appears to get fired three times each conversion, rather than one.