The Aether

The Aether

32M Downloads

Feature Request: Book of Lore grammar and consistency check

Zcaercat opened this issue ยท 4 comments

commented

What Feature Types Apply to This Request?

Item, Other (Please Describe)

Other Type

Grammar and Consistency

Is This an Enhancement to a Preexisting Feature?

  • I confirm this request is an enhancement to a feature already in The Aether.

What Is Your Feature Request?

(Since grammar and consistency in Book of Lore entries isn't really a bug, I'm using the Request template)

Several of the Book of Lore entries have capitalization errors or capitalize item or block names inconsistently. There are also several entries with comma splicing and awkward syntax.

Additionally, Book of Lore entries for Netherite Gloves, Aether Farmland, and Aether Dirt Path are missing and the Golden Gloves entry refers to the Gold Armor set as both "Golden Armor set" and "Gold Armor set".

For example, the Gravitite Axe entry states: "lore.item.aether.gravitite_axe": "Part of Aether's best tool tier, this Axe not only can make wood blocks float, but it can mine Golden Oak logs for Golden Amber!",. Axe is a common noun and would not normally be capitalized.
2023-07-09_20 22 50
AethDirtPath
AethFarmland
GravAxe
NethGloves

Why Should It Be in the Mod?

The comma splices can be left alone as a stylistic choice, but making capitalization consistent would add some polish and cleaning up some grammar and syntax would make reading easier.

Does This Feature Improve Compatibility With Another Mod?

No response

Please Read and Confirm the Following

  • I have confirmed this feature is either in the original Aether mod, or improves parity between The Aether and Minecraft or other mods.
  • I have confirmed this suggestion is unique and has not been suggested already.
commented

Note: The Cloud Staff refers to the summoned entities as "Cloud Sentries" but the source code refers to them as "Cloud Minion."

commented

Axe being capitalized is consistent with vanilla capitalization choices in Advancements

commented

Farmland and Dirt Path don't have entries due to being unobtainable blocks.

Actually we should probably just add lore entries anyways, the Chest Mimic is unobtainable yet has a lore entry.

commented

Farmland and Dirt Path don't have entries due to being unobtainable blocks.