The Aether

The Aether

Mods
35M Downloads

Bug: Mixin config can be used to block application of any Aether mixin

Jonathing opened this issue ยท 0 comments

commented

What Feature Types Apply to This Bug?

System

Other Type

No response

What Type of Bug Is This?

Unexpected Behavior

Forge Version

45.1.0

The Aether Version

git commit 37c5e24 on branch feat/bconlon/cleanup

Is This Bug a Conflict With Another Mod?

No response

Client Log

No response

Crash Report (if applicable)

No response

Steps to Reproduce

  1. Open config/aether/mixin_config.json
  2. Put in any aether mixin class name and set it to false.
  3. ???
  4. Profit (you potentially crash the game!)

What You Expect To Happen

The Aether mixin config should only be allowed to attempt changes to mixin classes that are pre-defined within the original config. It should not be possible to add an entry to a completely irrelevant mixin class, then allow the mod to disable that mixin on startup.

What Actually Happened

Nothing is stopping me from stopping the load of mixin com.aetherteam.aether.mixin.mixins.common.DimensionTypeMixin and breaking absolutely everything.

Additional Details

Wanna crash your game??? Here's a sample config for you to play with!

{
  "comment": "Disabling these is not advised unless necessary",
  "com.aetherteam.aether.mixin.mixins.client.AdvancementToastMixin": true,
  "com.aetherteam.aether.mixin.mixins.client.TippableArrowRendererMixin": true,
  "com.aetherteam.aether.mixin.mixins.common.DimensionTypeMixin": false
}

Feel free to assign this issue to me, I have already written up a PR that fixes this problem.

Please Read and Confirm The Following

  • I have confirmed this bug can be replicated without the use of Optifine.
  • I have confirmed this bug is on the most recently supported version of Minecraft.
  • I have confirmed the details provided in this report are concise as possible and does not contained vague information (ie. Versions are properly recorded, answers to questions are clear).
  • I have confirmed this issue is unique and has not been reported already.
  • If playing on a modpack, I have reported this issue to their issue tracker already.