The Aether

The Aether

32M Downloads

Bug: MoaType registry doesnt appear in registryaccess

GizmoTheMoonPig opened this issue ยท 0 comments

commented

What Feature Types Apply to This Bug?

Entity, System

Other Type

No response

What Type of Bug Is This?

Unexpected Behavior

Forge Version

45.1.16

The Aether Version

beta 5.1

Is This Bug a Conflict With Another Mod?

No response

Client Log

No response

Crash Report (if applicable)

No response

Steps to Reproduce

Since this is more technical, this isnt easy to reproduce on the fly without a bit of code.
All you need to do is attempt to fetch the moa type registry using registryaccess or HolderLookup>provider and youll see that it doesnt exist.

What You Expect To Happen

That I would be able to use the moa type registry in one of my mods (openblocks trophies) to add moa trophies when mods make new ones (such as lost content)

What Actually Happened

The game crashed since the registry apparently doesnt exist

Additional Details

Its a super simple fix. All you need to do is change this line to be
public static final Supplier<IForgeRegistry<MoaType>> MOA_TYPE_REGISTRY = MOA_TYPES.makeRegistry(() -> new RegistryBuilder<MoaType>().hasTags()); instead of
public static final Supplier<IForgeRegistry<MoaType>> MOA_TYPE_REGISTRY = MOA_TYPES.makeRegistry(RegistryBuilder::new);.
This allows the registry to be discoverable via registryaccess, and also allows you to make tags using registry entries if that's something you're interested in later down the line.

Please Read and Confirm The Following

  • I have confirmed this bug can be replicated without the use of Optifine.
  • I have confirmed this bug is on the most recently supported version of Minecraft.
  • I have confirmed the details provided in this report are concise as possible and does not contained vague information (ie. Versions are properly recorded, answers to questions are clear).
  • I have confirmed this issue is unique and has not been reported already.
  • If playing on a modpack, I have reported this issue to their issue tracker already.