Feature Request: Skyroot Plank lacks the "minecraft:plank" tag. Should it be added?
ffuentesm opened this issue ยท 14 comments
What Feature Types Apply to This Request?
Block, Item
Other Type
No response
Is This an Enhancement to a Preexisting Feature?
- I confirm this request is an enhancement to a feature already in The Aether.
What Is Your Feature Request?
I am mostly confused as to why the Skyroot plank lacks the plank tag if the Skyroot Log has the Minecraft:log tag.
Why Should It Be in the Mod?
For consistency and compatibility with other mods.
Does This Feature Improve Compatibility With Another Mod?
yes, any mod that interact with planks.
Please Read and Confirm the Following
- I have confirmed this feature is either in the original Aether mod, or improves parity between The Aether and Minecraft or other mods.
- I have confirmed this suggestion is unique and has not been suggested already.
Using the #minecraft:plank tag causes conflicts for Aether recipes like Skyroot Beds and Skyroot Tools, so the plank tag cannot be applied to Skyroot Planks. I would like to write up a NeoForge PR in the future to allow workarounds for conflicts like that, but I have not had the time.
A way to solve that, that I use at least, is the Polymorth mod, which fixes "duplicated recipes" and allows for the user to choose the recipe output. From what I see, moded recipes have priority over the vanilla tags.
I manually added the tag to the skyroot plank and from testing, I see no conflict with the recipes.
As you can see in Polymorph. The Aether recipes take priority over the vanilla recipe outputs.
So even without Polymorth, you get Skyroot items over the vanilla items. And with Polymorph you can then get the vanilla items.
Well, I have been playing with a custom datapack that adds the tags to the aether blocks, and so far, no incompatibility has happened. aether_tweaks.zip
From that I understand, since Aether tools use the item ID for the craft, they take priority over tag recipes. I also added the milk and water tags to the skyroot buckets. and so far, they work as intended.
Also, in regards to datapacks, there is the polymorph mod that can fix any unforeseen craft incompatibility
I wonder if because using a custom datapack means youre assumedly loading it with the world startup as opposed to game startup, that somehow causes the Aether recipes to guarantee priority. I have seen a similar situation with addon recipes vs base mod recipes where load stage can determine recipe priority between the two, but hadn't considered if this also applies to the next level down with base mod vs minecraft. If so, I may have to do some testing to investigate this.
@ffuentesm I cannot reproduce the functionality of your pack with the Aether.
I see this was closed, but it is quite a detriment to modpacks where planks have many uses beyond vanilla and skyroot planks cannot be used in any of those recipes.
As it stands Minecraft does not have wooden variants for blocks like bookshelves and beds, so I do not believe The Aether should either until Minecraft itself does.
I know that might not be a popular opinion as these items have been in the mod for so long but it would solve the conflicts in a vanilla-friendly way.
Skyroot Tools, Buckets, etc would also have to be removed which are a core part of the mod so that will not happen
Buckets would not have to be removed as Minecraft does not have wooden buckets.
Does there really need to be a "skyroot stick" that doesn't work with any vanilla or modded recipes? Same could be said for skyroot tools when Minecraft already has wooden tools etc.
Progression should take vanilla into account while complementing it - see the Nether which offers nylium as its wood and blackstone as its stone-replacement, these blocks make regular wooden and stone tools and this isn't a problem.
But I suspect nostalgia will play a big part in these duplicates staying in the mod, for a better or worse experience.
Skyroot tools have unique abilities, they aren't the same as vanilla wood tools, hence the differing/incompatible recipes/materials. It's not something we'll be changing
It's an awkward but understandable situation - I only hope some steps can be taken to mitigate the incompatibilities (using tags instead of skyroot sticks directly in recipes for example).
As mentioned by bconlon1 what's really needed is a Forge mechanic to allow these items to be crafted while also including them in the tag, as that would solve the same problem for a plethora of item variants in modded Minecraft.
Well, I have been playing with a custom datapack that adds the tags to the aether blocks, and so far, no incompatibility has happened.
aether_tweaks.zip
From that I understand, since Aether tools use the item ID for the craft, they take priority over tag recipes.
I also added the milk and water tags to the skyroot buckets. and so far, they work as intended.
Also, in regards to datapacks, there is the polymorph mod that can fix any unforeseen craft incompatibility
the buckets would also be overwritten by the bowl recipe
Not really
As you can see, if you add Polymorph you get both options too.
Buckets would not have to be removed as Minecraft does not have wooden buckets.
Does there really need to be a "skyroot stick" that doesn't work with any vanilla or modded recipes? Same could be said for skyroot tools when Minecraft already has wooden tools etc.
Progression should take vanilla into account while complementing it - see the Nether which offers nylium as its wood and blackstone as its stone-replacement, these blocks make regular wooden and stone tools and this isn't a problem. But I suspect nostalgia will play a big part in these duplicates staying in the mod, for a better or worse experience.
I feel that the skyroot tools are nice, as they are the efficient tools in the aether and add an air of uniqueness. I still would like the use of tags for mod compatibility as it would allow for an "aether run" without needing to get different types of saplings to craft other mod items. Same reason why I also added the Holystone the minecraft:stone_crafting_materials to it, which allows holystone to be used on block crafting but not the vanilla stone tools. So it can craft things such as pistons, furnaces, dispenses, anything that uses a cobblestone replacement.
But a suggestion that I have to fix this is to just have the recipe use "forge:rods/skywood" or use the item id as the priority.
Like how Immersive Engineering does it with their treated wood items
