The Aether

The Aether

32M Downloads

Bug: Event Hook causing low TPS on Multiplayer Server MC 1.19.2

xkobalx opened this issue ยท 8 comments

commented

What Type of Bug Is This?

Performance

Forge Version

43.2.21

The Aether Version

1.19.2-1.0.0-beta.1.2-forge

Steps to Reproduce

Only effecting some players.
On player log in.
image
This event appears on the profiler and there are constant tps issues.
This event is triggering no matter what dimension the player is in or where they are in those dimensions.
The issue will sometimes disappear for a minute or two before resuming.
The image shows 10% but it has gone as high as 25%.
Effected players log out.
The issue stops immediately.

What You Expect To Happen

The event should not be constant and should not be using so much of the servers resources.

What Actually Happened

Event triggering when certain players log in causing TPS issues.

Additional Details

Issue persists on the effected players between reboots and logins.

Other players have been to the Aether, to the same areas and have completed the same content but are not effected.

Dedicated Server
Server is running Java 17.0.8.1
AMD Ryzen 9 5950x
16GB of 64GB RAM allocated to MC
Running on NVME RAID.

Please Read and Confirm The Following

  • I have confirmed this bug can be replicated without the use of Optifine.
  • I have confirmed this bug is on the most recently supported version of Minecraft.
  • I have confirmed the details provided in this report are concise as possible and does not contained vague information (ie. Versions are properly recorded, answers to questions are clear).
  • I have confirmed this issue is unique and has not been reported already.
  • If playing on a modpack, I have reported this issue to their issue tracker already.
commented

Can additionally confirm this, with Forge 43.3.0 and the same Aether version/ no optifine/custom modpack. This issue appears with the config option "Disables falling into the Overworld" set to TRUE and before any player on the server has even entered the aether.

See(as one example); https://spark.lucko.me/IJLpxSULDc

EDIT: notably, seems to happen to a player that has placed the portal and then not gone in. will update if that fixes the issue.

commented

I need to rearrange the checks starting here:

for (Entity entity : serverLevel.getEntities(EntityTypeTest.forClass(Entity.class), Objects::nonNull)) {

commented

Could we get the beta jar with the fix for 1.19.2 as well, or would the fix be the same if I backported the relevant commit and built it myself?

commented

Thank you!

commented

I can backport the fix for testing, I will get back to you once that is done

commented

Initial test shows it's fixed. Will keep fiddling and see.