Bug: Tags do not work correctly in repairing recipes
Partonetrain opened this issue · 4 comments
What Feature Types Apply to This Bug?
Other (Please Describe)
Other Type
Crafting
What Type of Bug Is This?
Design
Mod Loader
NeoForge
Mod Loader Version
21.1.115
The Aether Version
1.21.1-1.5.3
Is This Bug a Conflict With Another Mod?
no
Client Log
n/a
Crash Report (if applicable)
n/a
Steps to Reproduce
- Create a datapack with this recipe:
{
"type": "aether:repairing",
"ingredient": {
"tag": "minecraft:enchantable/durability"
},
"repairTime": 1500
}
(any valid tag will demonstrate this)
2. Attempt to perform recipe in-game:
3. observe the incorrect output:
(it seems to be leather boots because that happens to be the 0th item in the #minecraft:enchantable/durability tag)
What You Expect To Happen
The item that was input it output, but repaired
What Actually Happened
leather boots were output
Additional Details
Unrelated, but CraftTweaker does not consider aether:repairing a recipetype. However, <recipetype:aether:enchanting>.removeByRegex("aether:.*_repairing"); seemed to work for removing all other repairing recipes. (This is just a note, having this script or not does not change the outcome of the custom recipe)
Please Read and Confirm The Following
- I have confirmed this bug can be replicated without the use of Optifine.
- I have confirmed this bug is on the most recently supported version of Minecraft.
- I have confirmed the details provided in this report are concise as possible and does not contain vague information (ie. Versions are properly recorded, answers to questions are clear).
- I have confirmed this bug is unique and has not been reported already.
- If playing on a modpack, I have reported this bug to their issue tracker already.
- I have confirmed that I'm reporting a bug in The Aether I, not The Aether II.
Actually nevermind, immediately noticing that it still isn't doable since there's not input slot context for the recipe book's display of results; might have to save this for looking into in 1.21.4 where there were changes to the recipe book code.
Repairing isn't a separate recipe type, it's just a separate recipe serializer type, so that would be why CraftTweaker wouldn't distinguish it. As for the tag support, I'll see if I can get that working; it previously was considered intended that it didn't work with tags due to a limitation with recipe results but some changes in 1.21.1 might make it doable now.
If it helps anyone out there, I made a quick Python script that generates repair recipes for datapack developers (or modders for that matter):
https://github.com/Partonetrain/AetherRepairRecipeGen