The Aether

The Aether

Mods
43M Downloads

Bug: Mixin Priority Conflict with Music Moods

HAWK-6155 opened this issue ยท 2 comments

commented

What Feature Types Apply to This Bug?

Audio

Other Type

No response

What Type of Bug Is This?

Compatibility

Mod Loader

Fabric

Mod Loader Version

0.16.9

The Aether Version

1.5.2-beta2-fabric

Is This Bug a Conflict With Another Mod?

Music Moods 0.4.2+mc.1.20

Client Log

No response

Crash Report (if applicable)

https://gist.github.com/HAWK-6155/41749ad8d8a54a14ae7f4e9f333ccb42

Steps to Reproduce

Occurs: Every time

  1. Install Music Moods
  2. Install The Aether
  3. Attempt to launch Minecraft with mods

What You Expect To Happen

Minecraft should launch.

What Actually Happened

Minecraft crashes, due to Music Moods and The Aether having the same Mixin priority for net/minecraft/class_1142::method_18669.

Additional Details

The issue is due to conflicting injections for managing music.

Music Moods makes ambient music dynamic by switching or triggering music depending on the player's current location - and The Aether does the same thing due to special music for boss fights and certain areas in The Aether. However, since The Aether and Music Moods have the same Mixin priority, Music Moods can't override The Aether or vice-versa.

Ideally, The Aether should allow Music Moods to control the music, as it would provide dynamic music everywhere and should still operate The Aether's custom music triggers. If The Aether overrode Music Moods, dynamic music would only work in The Aether dimension and nowhere else.

Please Read and Confirm The Following

  • I have confirmed this bug can be replicated without the use of Optifine.
  • I have confirmed this bug is on the most recently supported version of Minecraft.
  • I have confirmed the details provided in this report are concise as possible and does not contain vague information (ie. Versions are properly recorded, answers to questions are clear).
  • I have confirmed this bug is unique and has not been reported already.
  • If playing on a modpack, I have reported this bug to their issue tracker already.
  • I have confirmed that I'm reporting a bug in The Aether I, not The Aether II.
commented

Well you see it seems that they are doing a Overwrite which seems to be causing issues with targeting of Cumulus Mixin: https://github.com/Modflower/music-moods/blob/9f1cfe1194f92ca8444e03c000e84e52280eaa84/src/main/java/gay/ampflower/musicmoods/mixin/MixinMusicManager.java#L59

commented

From Ampflower (MusicMoods creator):

The problem is simple.

https://github.com/The-Aether-Team/Cumulus/blob/c6b1a7d7d3a3eb940e5b34a50b42409370a7a891/src/main/java/com/aetherteam/cumulus/mixin/mixins/client/MusicManagerMixin.java#L19-L25

Cumulus injects into the music manager expecting the tick function to never change.

The solution meanwhile, is not; the overwrite would have to be rewritten to allow for original injects to exist.

So... would this mean this is something Ampflower needs to fix in MusicMoods? Or is it something that could be patched in Cumulus?

My apologies as I am not very familiar with the Mixin system - the last time I worked on a Minecraft mod was when Forge was the only option, and we had to remember to delete META-INF.