The Aether

The Aether

Mods
44M Downloads

Bug: Milk Bucket Fluid Capabilities

VoidLeech opened this issue ยท 0 comments

commented

What Feature Types Apply to This Bug?

Item

Other Type

No response

What Type of Bug Is This?

Unexpected Behavior

Mod Loader

Neoforge

Mod Loader Version

47.1.70, 21.1.72

The Aether Version

1.5.2, 1.5.4

Is This Bug a Conflict With Another Mod?

No response

Client Log

No response

Crash Report (if applicable)

No response

Steps to Reproduce

  1. Query for ForgeCapabilities.FLUID_HANDLER_ITEM/Capabilities.FluidHandler.ITEM on a stack of the Skyroot Milk Bucket
  2. Call getContainer() on the handler.

What You Expect To Happen

The returned container is a skyroot bucket.

What Actually Happened

On 1.21.1, there is no capability.
On 1.20.1, this returned container is a normal bucket, not a skyroot bucket. This can seen in action with a mod like Create, which generates certain recipes from fluid capabilities: Creators-of-Create/Create#7084

Additional Details

Code analysis:
1.20.1 registered the capability via MilkBucketItem while 1.21.1 doesn't, explaining the missing capability.

1.20.1's MilkBucketItem's initCapabilities should be overridden: it currently returns a FluidBucketWrapper, whose default setFluid method will set the container to a normal bucket if the fluid is empty)

Please Read and Confirm The Following

  • I have confirmed this bug can be replicated without the use of Optifine.
  • I have confirmed this bug is on the most recently supported version of Minecraft.
  • I have confirmed the details provided in this report are concise as possible and does not contain vague information (ie. Versions are properly recorded, answers to questions are clear).
  • I have confirmed this bug is unique and has not been reported already.
  • If playing on a modpack, I have reported this bug to their issue tracker already.
  • I have confirmed that I'm reporting a bug in The Aether I, not The Aether II.