Bug: Crash upon entering the portal - Error soundInstance is Null
richiehailstone opened this issue ยท 15 comments
What Feature Types Apply to This Bug?
Audio, Other (Please Describe)
Other Type
I think either Audio or Block, I'm not sure.
What Type of Bug Is This?
Crash
Mod Loader
Fabric
Mod Loader Version
0.16.7
The Aether Version
aether-1.20.1-1.5.2-beta.4-fabric
Is This Bug a Conflict With Another Mod?
Yeah almost certainly. I have a ton of mods installed. Just hoping to see if you had any ideas on what the culprit mod is or a potential fix
Client Log
https://gist.github.com/richiehailstone/91dad2a8a4f652194e09a2aa0ae089cb
Crash Report (if applicable)
https://gist.github.com/richiehailstone/c6082be27a9e17ddf75fac542a6bea24
Steps to Reproduce
Enter Portal
Load for a few seconds
Crash
What You Expect To Happen
Load into the aether dimension
What Actually Happened
Ctd
Additional Details
After the crash, I tried to reload into my world and try again. When my game loaded, I spawned in inside the portal in my base in the overworld, I hear the aether portal sounds play for a couple seconds, but then this time it freezes with the "minecraft is not responding" instead of the crash trying to enter the dimension like the first time.
I also tried removing the mod "visual overhaul" as i saw someone had a similar issue a long time ago with with sound being null but that didn't work.
No worries if this is unfixable, i know i have a huge mod list, and you can't guarantee compatibility with every mod out there.
Please Read and Confirm The Following
- I have confirmed this bug can be replicated without the use of Optifine.
- I have confirmed this bug is on the most recently supported version of Minecraft.
- I have confirmed the details provided in this report are concise as possible and does not contain vague information (ie. Versions are properly recorded, answers to questions are clear).
- I have confirmed this bug is unique and has not been reported already.
- If playing on a modpack, I have reported this bug to their issue tracker already.
- I have confirmed that I'm reporting a bug in The Aether I, not The Aether II.
While I'm not sure about the Create crash mentioned here, it turns out the sound issue had an Aether root cause discovered after #2579
Tried "aether-1.20.1-1.5.2-beta.5-fabric" and game ctd upon loading up my world.
https://gist.github.com/richiehailstone/da37d8bafe89716e4eff6fe63242bc9c
https://gist.github.com/richiehailstone/56a9d6e3b2ea8a93f9a266c9665cbd02
Yes this seems to be another crash pointing to Create like before, you should report it to them as I've mentioned.
Well, my modpack works perfectly without Aether. So I'm not sure if it's the best idea for me to bug them. But I'll stop bugging you. Hopefully this hotfix works for @r8tten and others. Thanks
This is a compatibility issue, so yes removing Aether would fix it. Removing Create would probably also fix it. It'd be worth reporting in case anyone else has this issue so it can be resolved.
It seems this issue is from Bad Wither No Cookie, although the Aether Portal seems to be in the stacktrace from the portal sounds since the crash seems to be from BWNC mixining into the sound playing method, but the code for the Aether Portal sound should align with the Nether Portal so I think the problem is on their end unless I'm missing something; it seems like their mixin should be doing a null check here: https://gitlab.com/kreezxil/BadWitherNoCookie/-/blob/1.20.x/fabric/src/main/java/com/kreezcraft/badwithernocookiereloaded/mixin/SoundEngineMixin.java?ref_type=heads#L22. Although I'm not sure how that value is even ending up null since the Aether Portal code doesn't pass in a null value there, so maybe some other mod is messing with that as well.
It seems this issue is from Bad Wither No Cookie, although the Aether Portal seems to be in the stacktrace from the portal sounds since the crash seems to be from BWNC mixining into the sound playing method, but the code for the Aether Portal sound should align with the Nether Portal so I think the problem is on their end unless I'm missing something; it seems like their mixin should be doing a null check here: https://gitlab.com/kreezxil/BadWitherNoCookie/-/blob/1.20.x/fabric/src/main/java/com/kreezcraft/badwithernocookiereloaded/mixin/SoundEngineMixin.java?ref_type=heads#L22. Although I'm not sure how that value is even ending up null since the Aether Portal code doesn't pass in a null value there, so maybe some other mod is messing with that as well.
I don't have Bad Wither No Cookie Installed so cant be that
Why was this closed?
It was closed because it's not an issue fixable on our end if its BWNC. Which seems to be installed according to the log you provided: https://gist.github.com/richiehailstone/c6082be27a9e17ddf75fac542a6bea24#file-gistfile1-txt-L253
Hey thanks for looking into my issue, I tried removing BWNC and it crashed a couple of seconds after joining my world. Weird.
I know you closed the issue but here's the logs:
https://gist.github.com/richiehailstone/9d2ad0b50730f2da4ca91da8ff82d05a
https://gist.github.com/richiehailstone/09cc7d4ad8b36332318bd997b4a3bfe9
Maybe Aether just isn't destined to work with my mod list. Thanks regardless!
Edit: Figured I should add that it doesnt crash if i only remove BWNC...it crashes when I remove it AND add Aether back in
This new crash seems to be coming from Create now I think, and I'm not seeing Aether in the stacktrace.