Bug: Crashing when portal sound is playing
r8tten opened this issue · 12 comments
What Feature Types Apply to This Bug?
Audio
Other Type
No response
What Type of Bug Is This?
Crash
Mod Loader
Fabric
Mod Loader Version
0.16.10
The Aether Version
1.20.1-1.5.2 Beta 4
Is This Bug a Conflict With Another Mod?
Probably
Client Log
https://gist.github.com/r8tten/4e612a6e1c841ee54bdfb2fef033da8d
Crash Report (if applicable)
https://gist.github.com/r8tten/2680c339c2e2ed49067a56c48573c696
Steps to Reproduce
- Create The Aether Portal
- Wait for the portal sound
- profit???
What You Expect To Happen
The game to continue with the portal sounds and the game to not crash
What Actually Happened
It crashed
Additional Details
Not sure what other mod causes it but
net.minecraft.class_1113.method_4774() returns as null
Please Read and Confirm The Following
- I have confirmed this bug can be replicated without the use of Optifine.
- I have confirmed this bug is on the most recently supported version of Minecraft.
- I have confirmed the details provided in this report are concise as possible and does not contain vague information (ie. Versions are properly recorded, answers to questions are clear).
- I have confirmed this bug is unique and has not been reported already.
- If playing on a modpack, I have reported this bug to their issue tracker already.
- I have confirmed that I'm reporting a bug in The Aether I, not The Aether II.
Figured out the issue, there will be a hotfix tomorrow possibly.
Thanks for looking into it
Figured out the issue, there will be a hotfix tomorrow possibly.
What was the bug
Good morning. I can reliably reproduce this crash with only The Aether and Dynamic FPS. When the portal sound is playing in Singleplayer, if you pause the game the game will crash. Here's a gist of a clean log without any additional mods:
https://gist.github.com/Jonathing/f3945c7289647fd465bd1933c009caa3
I suspect this might be a bug with Dynamic FPS, but it might be worth checking your implementation of FadeOutSoundInstance.
Good morning. I can reliably reproduce this crash with only The Aether and Dynamic FPS. When the portal sound is playing in Singleplayer, if you pause the game the game will crash. Here's a gist of a clean log without any additional mods:
https://gist.github.com/Jonathing/f3945c7289647fd465bd1933c009caa3
I suspect this might be a bug with Dynamic FPS, but it might be worth checking your implementation of
FadeOutSoundInstance.
Did the issue go away without Dynamic FPS?
I can afford not to use it in the meantime while something is fixed
Just a quick edit, I removed Dynamic FPS and still crashed with the following error
The game crashed: unexpected error Error: java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1113.method_4775()" because "soundInstance" is null
Like @Jonathing said maybe look into FadeOutSoundInstance
Ah, in that case Dynamic FPS is probably wrapping the sound early. Stacktraces can be misleading like this at times.
But yeah check implementations. Maybe the sound is still playing even though the sound instance itself has stopped?
Ah, in that case Dynamic FPS is probably wrapping the sound early. Stacktraces can be misleading like this at times.
But yeah check implementations. Maybe the sound is still playing even though the sound instance itself has stopped?
I actually found it be the opposite haha. Dynamic FPS delayed the crash for a few seconds, as apposed to not having it installed it crashed almost instantly
If this crash occurs without Dynamic FPS, can you provide a log without it installed please?
If this crash occurs without Dynamic FPS, can you provide a log without it installed please?
Crash report:
https://gist.github.com/r8tten/2ad031f07f30ff05e6d34b5d05905726
Client log:
https://gist.github.com/r8tten/cf32fd47d35fe6ef1a1ad0685a031266
