Angelica

Angelica

9.7k Downloads

Some custom block rendering is broken again (Et Futurum Requiem)

Roadhog360 opened this issue · 1 comments

commented

Your GTNH Discord Username

roadhog360

Mod Version

angelica-1.0.0-alpha14

Java Version

Java 8

Bug Report

  • Java 8 202 as provided by the Minecraft launcher

I did attempt to search for this issue, but do let me know if this was already reported in a different issue and I can move this information to that report instead.

Certain custom geometry, namely with non-opaque blocks appears to be broken once again. This issue was observable in some pre-alpha versions of Angelica, but was fixed before alpha 1 or not long after it. However, the issue has returned as of alpha 12. This issue is not present on alpha 11 and prior.

Notable artifacts include that some geometry does not appear, others are not subject to directional shading and bamboo for instance is always rendered fully bright.

Feel free to point out any criticisms in my render code; I wouldn't be surprised if it could be improved, I am not particularly good at this.

Broken version (Some rendering is missing, directional shading is broken for these blocks)
2024-01-15_23 59 25

Bamboo is fully bright
2024-01-16_00 06 49

Correct version (Note the directional shading, chains and the lantern chain is present)
2024-01-16_00 01 09

Mod List or GTNH Pack Version

UCHIJAAAA	mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) 
UCHIJAAAA	FML{7.10.99.99} [Forge Mod Loader] (forge-1.7.10-10.13.4.1614-1.7.10.jar) 
UCHIJAAAA	Forge{10.13.4.1614} [Minecraft Forge] (forge-1.7.10-10.13.4.1614-1.7.10.jar) 
UCHIJAAAA	unimixins{0.1.15} [UniMixins] (+unimixins-all-1.7.10-0.1.15.jar) 
UCHIJAAAA	unimixins-mixin{0.1.15} [UniMixins: Mixin (UniMix)] (+unimixins-all-1.7.10-0.1.15.jar) 
UCHIJAAAA	unimixins-compat{0.1.15} [UniMixins: Compatibility] (+unimixins-all-1.7.10-0.1.15.jar) 
UCHIJAAAA	mixingasm{0.3} [UniMixins: Mixingasm] (+unimixins-all-1.7.10-0.1.15.jar) 
UCHIJAAAA	spongemixins{2.0.1} [UniMixins: SpongeMixins] (+unimixins-all-1.7.10-0.1.15.jar) 
UCHIJAAAA	mixinbooterlegacy{1.2.1} [UniMixins: MixinBooterLegacy] (+unimixins-all-1.7.10-0.1.15.jar) 
UCHIJAAAA	gasstation{0.5.1} [UniMixins: GasStation] (+unimixins-all-1.7.10-0.1.15.jar) 
UCHIJAAAA	gtnhmixins{2.2.0} [UniMixins: GTNHMixins] (+unimixins-all-1.7.10-0.1.15.jar) 
UCHIJAAAA	mixinextras{0.1.15} [UniMixins: MixinExtras] (+unimixins-all-1.7.10-0.1.15.jar) 
UCHIJAAAA	mcpatcherforge{1.0.0-alpha} [MCPatcherForge] (angelica-1.0.0-alpha14.jar) 
UCHIJAAAA	embeddium{1.0.0-alpha14} [Embeddium] (angelica-1.0.0-alpha14.jar) 
UCHIJAAAA	angelica{1.0.0-alpha14} [Angelica] (angelica-1.0.0-alpha14.jar) 
UCHIJAAAA	notfine{1.0.0-alpha14} [NotFine] (angelica-1.0.0-alpha14.jar) 
UCHIJAAAA	etfuturum{2.6.0} [§5§oEt Futurum Requiem] (Et_Futurum_Requiem-2.6.0-SNAPSHOT-036b1642+nomixin.jar) 
UCHIJAAAA	gtnhlib{0.0.13} [GTNH Lib] (gtnhlib-0.0.13.jar) 

Final Checklist

  • I have searched the issues and haven't found a similar issue.
  • I have read the known incompatibilities and this is not related to one of those.
  • I am running an officially released version. (Or, if I've compiled it myself I plan to fix the issue)
  • This issue is not shader related (they aren't ready yet for testing)
commented

This is fixed by Et-Futurum-Requiem/29d7c0b, even if I remove the annotations. This implies that the issue was my use of a singleton tessellator instance. The bug happens even if I disable everything related to chunk rendering in the settings menu (did not test configs) but I am willing to bet other mods that do the same thing will have a similar issue. While I have not done extensive testing I believe my theory is almost certainly true, because if I load a build of EFR a commit before Mitchej's commit, the issue returns on alpha 19.

Closing since this issue is about EFR's renderers, but I think this issue report should be noted in case any other mods show a similar issue in the future.