
Join, immediately disconnect, crash
StrongSilentLanguage opened this issue · 8 comments
Your GTNH Discord Username
natoc72
Your Pack Version
2.7.0
Your Server
private server
Java Version
Java 8
Type of Server
None
Your Actions
Attempting to connect new account to new world. Previous version would connect, then immediately disconnect citing an index out of bounds error. Updated server and client to 2.7, successfully connect, immediately crash
Crash Report
Final Checklist
- I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the crash still exists will prompt us to investigate and reopen it once we confirm your report.
- I can reproduce this crash consistently by following the exact steps I described above.
- I have asked other people and they confirm they also crash by following the exact steps I described above.
Found 1 linked crash report(s)
Primitive Automated Analysis of Crash Report
https://mclo.gs/QydRVO8
Possibly an Angelica problem. Try remove this mod and see if this fixes your problem.
Stacktrace
java.lang.RuntimeException: Chunk build failed at me.jellysquid.mods.sodium.client.render.chunk.compile.ChunkBuilder.handleFailures(ChunkBuilder.java:219) at me.jellysquid.mods.sodium.client.render.chunk.ChunkRenderManager.updateChunks(ChunkRenderManager.java:590) at me.jellysquid.mods.sodium.client.render.SodiumWorldRenderer.updateChunks(SodiumWorldRenderer.java:249) at net.minecraft.client.renderer.RenderGlobal.clipRenderersByFrustum(RenderGlobal.java:7195) at net.minecraft.client.renderer.EntityRenderer.renderWorld(EntityRenderer.java:1181) at net.minecraft.client.renderer.EntityRenderer.updateCameraAndRender(EntityRenderer.java:1011) at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1001) at net.minecraft.client.Minecraft.run(Minecraft.java:6110) at net.minecraft.client.main.Main.main(SourceFile:148) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) at net.minecraft.launchwrapper.Launch.main(Launch.java:28) Caused by: java.lang.ArrayIndexOutOfBoundsException: 12 at com.emoniph.witchery.blocks.BlockCircleGlyph.getIcon(BlockCircleGlyph.java:76) at net.minecraft.block.Block.getIcon(Block.java:556) at net.minecraft.client.renderer.RenderBlocks.getBlockIcon(RenderBlocks.java:8227) at net.minecraft.client.renderer.RenderBlocks.renderStandardBlockWithAmbientOcclusionPartial(RenderBlocks.java:5339) at net.minecraft.client.renderer.RenderBlocks.renderStandardBlock(RenderBlocks.java:4247) at net.minecraft.client.renderer.RenderBlocks.renderBlockByRenderType(RenderBlocks.java:255) at me.jellysquid.mods.sodium.client.render.pipeline.BlockRenderer.renderModel(BlockRenderer.java:103) at me.jellysquid.mods.sodium.client.render.chunk.tasks.ChunkRenderRebuildTask.performBuild(ChunkRenderRebuildTask.java:177) at me.jellysquid.mods.sodium.client.render.chunk.compile.ChunkBuilder$WorkerRunnable.run(ChunkBuilder.java:409) at java.lang.Thread.run(Thread.java:748)
Angelica mod does not appear to be included in the version I have. At minimum, I cannot find a file in the mod folder or any other with that name
That being said, the actual crash comes from witchery it seems
since witchery is ARR, a fix would be a mixin in angelica?
Yeah, if there’s a thread safety issue in Witchery’s block icons, I’d rather fix that in Angelica directly than in like WitcheryExtras or whatever. I’ll try and take a look in the next day or two. Most of these issues were just fixing with ASM directly in Angelica so that we don’t need compile deps on every mod under the sun.
I'm not sure what combination of things is causing the invalid metadata, that's gonna be insanely hard if even possible to get to the bottom of, it could be any number of mod combinations or interactions breaking something. However, I've added a PR to hodgepodge which at least causes it to not crash: GTNewHorizons/Hodgepodge#448
I've added to hodgepodge because this seems to be more of a general problem with Witchery, and the code in witchery which was supposed to prevent a crash from it is just categorically wrong, so seemed more fitting to not to the fix to Angelica.