Shaders detecting Iris to disable features on Optifine
leumasme opened this issue · 3 comments
Your GTNH Discord Username
leumasme
Mod Version
1.0.0-beta25
Bug Report
It seems like some shaders like Compementary Unbound check if they're running in Optifine or Iris via #if defined IS_IRIS ....
If it's not running in Iris and shader settings are set to enable features not supported by optifine like colored lighting, the shader refuses to work properly.
By manually patching the check out of a shader, I can see that Angelica seems to support colored lighting, and I'd imagine its nearly fully compatible since it's based on iris?
Would it be a good idea to define IS_IRIS for shader code to stop shaders from locking angelica users out of features?
In that case, probably also set another flag that mods can use to tell angelica apart from iris, and detect iris explicitly. Hmm i'm getting some user-agent header vibes... must've been the wind
Java Version
Java 21
Graphics Card Vendor
NVidia
Shaders
Yes: Please put relevant information about shaderpack in the report(what shaderpack, any special settings of note, etc)
MCPF or other features disabled by default
No: Go ahead and create an issue
Mod List or GTNH Pack Version
GTNH 2.7.0
Final Checklist
- I have searched the issues and haven't found a similar issue.
- I have read the known incompatibilities and this is not related to one of those.
- I am running an officially released version. (Or, if I've compiled it myself I plan to fix the issue)
We've talked to the Comp. devs, and defined an IS_ANGELICA tag for them to use. We don't currently define IS_IRIS because we don't fully support Iris's features at the time that flag was made, although we might be able to add it as an experimental setting.
One thing one of the Euphoria patch devs suggested was looking at various feature flags that Iris introduced and reporting those as they are supported. IS_IRIS might be worth a try as an optional setting defaulting to Off, I'd say.