Angelica

Angelica

125k Downloads

RenderWorldEvent.Pre and RenderWorldEvent.Post are not emitted

szuend opened this issue · 3 comments

commented

Your GTNH Discord Username

nimO#7817

Mod Version

1.0.0-beta35

Bug Report

The two forge events (RenderWorldEvent.*) are not emitted when Angelica is present.

I assume that this is intentional but I couldn't find anything that explicitly mentions this in the docs or code. I propose to close this bug as WAI and maybe update the "known incompatibilities" list for the next dev stumbling over this.

Java Version

Java 21

Graphics Card Vendor

NVidia

Shaders

No

MCPF or other features disabled by default

No: Go ahead and create an issue

Mod List or GTNH Pack Version

N/A

Final Checklist

  • I have searched the issues and haven't found a similar issue.
  • I have read the known incompatibilities and this is not related to one of those.
  • I am running an officially released version. (Or, if I've compiled it myself I plan to fix the issue)
commented

What specific mod is this causing an issue with and what's the usecase? There's not many usages of it on all of the repos in the NH org so it wasn't noticed.

It wasn't specifically intentional, but thinking through the implications it's not clear that we would actually want to enable it... 🤔

commented

I noticed it while prototyping a small mod idea.

I mentioned the use case on the discord a couple days ago: I used the event to render a dynamically generated texture on the side of a block. The texture itself only rarely changes so it's more efficient to create it once upfront and then render the dynamic texture during the hook.

Normally I'd render it as part of the standard ISBRH, but those don't allow to bind other textures (only the atlas sprite). With vanilla forge this works rather well, as the hooks are part of the ISBRH display list.

I'm not advocating to unblock this use-case, as it can be solved via a TESR as well, just wanted to save the next dev some work when looking for answers :)

commented

FluxLoading also uses it, and I'm not sure they have other options.