AntiGhost

AntiGhost

Mods
3M Downloads

`/ghost` can kick you "for exceeding packet rate limit"

James103 opened this issue ยท 1 comments

commented

AntiGhost/src/main/java/de/guntram/mcmod/antighost/AntiGhost.java

Lines 53 to 62 in 9d803da

for (int dx=-4; dx<=4; dx++)
for (int dy=-4; dy<=4; dy++)
for (int dz=-4; dz<=4; dz++) {
PlayerActionC2SPacket packet=new PlayerActionC2SPacket(
PlayerActionC2SPacket.Action.ABORT_DESTROY_BLOCK,
new BlockPos(pos.getX()+dx, pos.getY()+dy, pos.getZ()+dz),
Direction.UP // with ABORT_DESTROY_BLOCK, this value is unused
);
conn.sendPacket(packet);
}

The above code loops 9 * 9 * 9 times, sending 729 ABORT_DESTROY_BLOCK packets in a single client-side game tick.
This can cause servers to kick you for sending too many packets.

To fix this,

  1. Wait a few milliseconds between each packet send.
  2. Send the packets from a separate thread (to facilitate item 1).
  3. Add a warning to the description page saying that using the mod may kick you from servers with low packet rate limits.
commented

Normal servers, no matter of Vanilla, Spigot, or Fabric, won't kick you. Nether will ViaVersion which has a rate limiter of 800, so the 729 is well within limits.

If a server owner decides to break their server by setting a lower limit, then it's their decision to do so. I won't take any countermeasures against that - it's the owners responsibility to have a working server, and I won't make my mods work around owners decisions.