Aqua Acrobatics [Forge]

Aqua Acrobatics [Forge]

2M Downloads

Issue with Galacticraft

Opened this issue ยท 9 comments

commented

There seems to be a compatibility problem with Galacticraft. When adding Galacticraft, it is impossible to sneak and go under a slab. This becomes like an "xray" bug.

I use MixinBootstrap, the latest version of Aqua Acrobatics, the latest version of Galacticraft and the latest version of Forge for 1.12.2.

2021-05-15_12 08 44
2021-05-15_12 04 42
2021-05-15_12 04 56

commented

GC integration seems to work fine from limited tests I did.

Great! Let me know if there are any other issues you encounter.

I can't place a slab right above my head while sneaking, but I'm not sure if that's related to this.

No, that happens without Galacticraft installed as well. I tried tracking it down, but there's something about 1.12's block placement algorithm that still considers the player to be 2 blocks tall, and honestly, I don't know if it's worth the effort to fix such a niche problem. Thanks for mentioning it, though.

commented

This is fixed by using Player API mod.

commented

Update: Player API from original project causes issues with GalactiCraft, while updated versions lead to Mixin-related crash with Aqua Acrobatics.

latest.log

commented

Can you link this updated Player API version?

commented

Yes. Player API is too invasive and breaks all of the mixins, unfortunately. The concept is good, but doesn't work too well with this mod.

commented

The issue is caused by the fact that both Galacticraft and Player API attempt to overwrite the vanilla player implementation with their own, whereas Aqua Acrobatics just augments the existing implementation using mixins (which is less invasive).

Compatibility with Player API will be difficult to add as it seems to replace everything from vanilla (this is the reason for the crash). However, doing the same augmentation to Galacticraft should be feasible.

I've published an experimental version of Aqua Acrobatics here that does exactly that. You will also need MixinBooter installed for the mixins that target Galacticraft to be enabled.

Please ensure that Player API is not installed, otherwise Aqua Acrobatics will crash.

If someone who plays with Galacticraft regularly can give this a try and see what it breaks, it would be appreciated! ๐Ÿ™‚

commented

Do I have to remove PlayerAPI when testing that build? I'll give it a spin.

commented

Just tried out latest CurseForge version - GC integration seems to work fine from limited tests I did. I can't place a slab right above my head while sneaking, but I'm not sure if that's related to this.