Aqua Acrobatics [Forge]

Aqua Acrobatics [Forge]

2M Downloads

[Compat] Eye height not changing based on ArtemisLib size

kappa-maintainer opened this issue ยท 7 comments

commented

2022-05-13_00 38 06
ArtemisLib's eye height logic is located at com.artemis.artemislib.util.AttachAttributes#onPlayerTick

commented

I made a patch mod to fix this and many other incompatibilities. It seems the eye height factor should multiple like this to get the correct eye height

commented

I'd prefer to have the compatibility fix within Aqua Acrobatics to avoid breakage and so an external mod is not needed, if you give permission. Your fix seems to make sense although I don't understand where the multiplication by 3 comes from?

commented

Yes, double mixin is always not a good idea. As for the factor 3, see here. My mod patched ArtemisLib to make it use CPM size but somehow made it multiple 1/3 twice here, so I have to revert it.

commented

@kappa-maintainer Does e3bfb9f work for your mod? I haven't released it yet in case it needs further tweaking.

commented

I will test this

commented

It works perfectly under many mod combinations, I should remove my double mixin now
How the 1/3 got multiplied twice is still a mystery though

commented

Great! Released as 1.14.1.