Baritone AI pathfinder

Baritone AI pathfinder

72.7k Downloads

#chests (or containerMemory) is broken

James-E-A opened this issue ยท 42 comments

commented

Some information

Operating system: Fedora 32
Java version: 11.0.10
Minecraft version: 1.16.5 (Fabric 0.11.1)
Baritone version: 1.6.3
Forge Fabric mods (if used): AppleSkin, NBTTooltip, Xaero's Minimap and Worldmap

Exception, error or logs

latest.log (Despite the folder name, I do not have Wurst installed.)

How to reproduce

  1. Run #set containerMemory true
  2. Open a chest, put things in it, close it
  3. Run #chests

Modified settings

  • allowParkour
  • assumeWalkOnWater
  • containerMemory

Final checklist

  • I know how to properly use check boxes
  • I have included the version of Minecraft I'm running, baritone's version and forge fabric mods (if used).
  • I have included logs, exceptions and / or steps to reproduce the issue.
  • I have not used any OwO's or UwU's in this issue.

I'm aware this is a duplicate of #2511, #2512, and #2513; but the reporter on those invalidated them by failing to follow procedure; I believe this instance is properly-formatted.

commented

do you got it fixed?

commented

Can i somehow help to fix this issue?

commented

Can you reproduce it @snoweuph? if so provide steps to reproduce it as I can't

commented

Some information

Operating system: Windows 10
Java version: 8,9, 16 (16 primary)
Minecraft version: 1.17.1
Baritone version: baritone-1.17-SNAPSHOT.jar
(got compiled version through meteor client https://www.youtube.com/watch?v=F8zpIb9gUhA)

For me that are these steps to Reproduce

  • Installing Fabrik 1.17.1 and Fabrik API
  • download latest release of meteor client https://meteorclient.com
  • unzip jar with winrar
  • go to meteor-client-0.4.5\META-INF\jars
  • copy baritone-1.17-SNAPSHOT.jar into your mods folder
  • start minecraft and go onto a server or singleplayer world
  • enable containerMemory in baritone settings ( settings page 9)
  • run #chests ( should return "No remembered inventories")
  • open a chest and put an item inside
  • run #chests again
  • should return some info, but just returns "No remembered inventories" again
commented

I will test diffrent things to see in wich versions I can reprodue it and to maybee find something meaningfull

commented

System Information

Operating system: Windows 10
Java version: 16

Process

  • Download Forge/Fabric installer.
  • Install Forge/Fabric
  • Download Baritone standalone Version for right Mod Launcher
  • Put jar into Mods-folder
  • Start Instalation
  • Create New World
  • Check if Setting containerMemory is true
  • Place Chest
  • run #chests
  • Put Items into Chest
  • run #chests

Reproduction Table

  • = Can Reproduce?
    NVF = No Version Found
Version Fabric Forge
1.17.1 - [x] NVF
1.16.5 - [x] - [x]
1.16.4 NVF - [x]
1.16.2 NVF - [x]
commented

@scorbett123 I think I mentioned being able to recreate this somewhere, if not that's my fault. I already knew about this half a year ago.

commented

The event handling in MemoryBehavior that took care of updating ContainerMemory was ripped out while updating to 1.14.4 in 8758c77 (ContainerMemory is still functional but not used anymore)

commented

The event handling in MemoryBehavior that took care of updating ContainerMemory was ripped out while updating to 1.14.4 in 8758c77 (ContainerMemory is still functional but not used anymore)

This could be the issue, I tested it on 1.12, so if a change happened in a non-master branch then it wouldn't have picked up on it.

I'll try to reproduce it again tonight on 1.16.

@snoweuph so you can't reproduce it on 1.12, if you can't, can you go through the versions to try and see which mc version this bug was introduced in

commented

Okay, so can I help with something else or do I just need to wait?

commented

I haven't tested so far down yet, I'm on My Way testing More version :)

commented

With what launcher do I install Release 1.3.8

commented
Version Fabric Forge
1.17.1 x NVF
1.16.5 x x
1.16.4 NVF x
1.16.2 NVF x
1.15.2 NVF x
1.12.2 NVF
commented

Works Fine in 1.12.2

commented

Ok, got to run with: #388
but baritone doesnt work at all

commented

So, can I help with something else our do I just need to wait?

just wait, thanks for finding all of this info, I'm currently having computer issues so unless someone else finds the issue before me, it may be a couple days until I can properly look into the cause of this issue

so the event handling being ripped out is not the issue? So far #chests worked on everything I tried before 8758c77 and did not work on anything I tried after that. Haven't tried on the direct parent/successor yet though.

commented

It could be, but I thought if its relevant @scorbett123 would have sayn someting about it

commented

Both

commented

So, can I help with something else our do I just need to wait?

just wait, thanks for finding all of this info, I'm currently having computer issues so unless someone else finds the issue before me, it may be a couple days until I can properly look into the cause of this issue

so the event handling being ripped out is not the issue? So far #chests worked on everything I tried before 8758c77 and did not work on anything I tried after that. Haven't tried on the direct parent/successor yet though.

from looking at it this should still work through packets, in MemoryBehavior it scans for chest packets and saves the data form them. I think at least that this is how it works, but as mentioned earlier, I can't get gradle working so can't test that this bit is actually working.

In that vein, is this just singleplayer, or does this also happen in multiplayer

commented

okay, so how do I setup a baritone standalone version, havnt found any real information

commented

ok, so between 1.12 and 1.15, that's why I haven't been able to replicate it.

commented

Yes, there is a reelease, but I havnt found Instructions on how to install it, no Forge and no Fabrik provided
https://github.com/cabaletta/baritone/releases/tag/v1.3.8

commented

what do you mean by that?

commented

How would I insstall it for 1.13 for example where I dont have a jar for a mod launcher

commented

I think you have probably narrowed it down far enough, for 1.13 there should be a release, however you may have to build it yourself, but I think the release should work (some features will be missing). Have you checked the releases tab?

commented

How would I install the baritone-standalone-1.3.8.jar?

commented

They should all be forge

commented

image

commented

uh, wait what

commented

I thought the Same, A releasee, but you ccan't usee it?

commented

Yea, idk how you use those releases, they were released before I started working on the project. Can you try it using impact 1.13, pretty certain that has baritone integrated.

commented

okay, I just read that you could Use them somehow as a Mineccraft Version dircetly, or something like this

commented

image

commented

N = Not tried
NVF = No Version Found
x = Error Found
= Error Not Found

Version Fabric Forge Impact
1.17.1 x NVF N
1.16.5 x x N
1.16.4 NVF x N
1.16.2 NVF x N
1.15.2 NVF x N
1.14.4 NVF NVF x
1.13.2 NVF NVF
1.12.2 NVF N
commented

So It was between 1.13.2 and 1.14.4

commented

So, can I help with something else our do I just need to wait?

commented

So, can I help with something else our do I just need to wait?

just wait, thanks for finding all of this info, I'm currently having computer issues so unless someone else finds the issue before me, it may be a couple days until I can properly look into the cause of this issue

commented

Okay, good luck :)

commented

I can't find where it is listening for packets after that commit. Can you maybe give me a link to the specific line?

commented

oh, wait, the commit my laptop is in is messed up, it has decided that I wasn't viewing the 1.15 branch, ok, yea, that was removed in that commit as well. Why tho? what was it doing that was so bad

commented

I can't reproduce this, are you sure that you opened a chest?

commented

@scorbett123 I'm quite certain that I opened multiple chests when reproducing this.

Could you send a screenshot of it working on your end? (And, are you on Fabric, or Forge?)