Better Statistics Screen

Better Statistics Screen

21M Downloads

[v3.9.6+fabric-1.20.4] Raw translation string under mobs statistics filter

xxxkingxl opened this issue ยท 2 comments

commented

What happened?

when viewing the mob statistics I tried to change the order and saw one option in a raw translation string instead of human text

image link essential mod: https://media.essential.gg/e61a4b2f-02e8-4c22-bf53-660982398000
image

Steps to reproduce

  1. open the statistics menu
  2. select mobs in the main filter
  3. try to switch order filter
  4. u see the raw translation text, "Default" and "Died to" (the raw translation text goes off the text box but is not visible out side of the textbox and u see only the first part: "betterstats.stat_type_phrase.minecraft...")

Relevant log output or crash report

https://paste.atlauncher.com/view/13b46cfc-7370-4199-876d-dfdd22f0f2fe

Other installed mods

  1. wurst
  2. essential
  3. modpack: Fabulously optimized (maybe usefull to know: crowdin translate (included in modpack))
  4. a few mod additions that should not be able conflict
  5. removed the controller mod and zoom mod (more, idk. I modify modpacks to fit my needs)
  6. item swapper
  7. lazy language loader
  8. not enough crashes
  9. no chat reports
  10. starlight
  11. very many players
  12. Xaero- 's minimap, 's worldmap & plus
  13. wakes
  14. cubes without borders
  15. betterf3
  16. A few mod additions that should not be able conflict and idk what I added more
  17. A vanilla tweaks texture pack what doesnt conflict with wurst or essential

image
image
image

Code of Conduct

  • I agree that if the issue is regarding a crash, I gave the logs and the crash report.
  • I agree that I will be available later for any follow-up questions to help diagnose and resolve the issue.
commented

Hello, and thanks for the bug report.
After looking into it, it appears that the text in question used the wrong translation key (aka betterstats.stat_type_phrase instead of betterstats.stattype_phrase). It also appears that I accidentally left that out for 1.20.4 only
image
Will fix that in the next update tho.

The crash

Also, as for the crash log you left in this report; It was unnecessary, as the crash was not caused by this mod. After looking into the crash report, it appears that the following line of code
gg.essential.gui.screenshot.providers.CloudflareImageProvider.loadImage(CloudflareImageProvider.kt:54)
was executed (by I assume "essential"), and it attempted to fetch an image from the internet, as seen here
java.io.IOException: Server returned HTTP response code: 403 for URL: https://imagedelivery.net/W9K_l6ndK9x4x8m3rurakg/e58dcbe4-a692-467f-09a0-94172434ed00//width=40,height=40
but the server returned HTTP CODE 403, resulting in an IOException being raised (you can think of exceptions as kinds of "errors" that can be handled by a program).

If this failure to fetch an image really did result in a crash, then if I were an Essential developer, I'd make sure I place error-handlers next time, so a crash don't take place. So in other words, if that was really a crash, you should probably report it to Essential developers.

-

Anyways, thanks again for reporting this bug, and have a great day!

commented

It didn't crash, but I added the console log, maybe it helps?!
Thanks for letting me know about this:

After looking into the crash report, it appears that the following line of code
gg.essential.gui.screenshot.providers.CloudflareImageProvider.loadImage(CloudflareImageProvider.kt:54)
was executed (by I assume "essential"), and it attempted to fetch an image from the internet, as seen here
java.io.IOException: Server returned HTTP response code: 403 for URL: https://imagedelivery.net/W9K_l6ndK9x4x8m3rurakg/e58dcbe4-a692-467f-09a0-94172434ed00//width=40,height=40
but the server returned [HTTP CODE 403](https://en.wikipedia.org/wiki/HTTP_403), resulting in an IOException being raised (you can think of exceptions as kinds of "errors" that can be handled by a program).

it doesn't give me issues now, but maybe later. I will look in to that issue in my modpack