Biomancy

Biomancy

311k Downloads

Bundles can be put in storage sacs

MarioSMB opened this issue ยท 2 comments

commented

Please complete the following information:

  • Forge-Version: 47.2.20
  • Mod-Version: 2.4.4.0

Describe the bug

Minecraft bundles can be placed inside storage sacs.

Expected behavior

Perhaps a tag should exist (if one doesn't already?) to prevent certain items from going into the storage sacs, to avoid other inventories being placed inside them.

Additional context

commented

I use the Item#canFitInsideContainerItems method on items to check if they are allowed to be inserted inside the storage sac.
So any (mod) item that overrides the method and returns false can't be inserted.

Bundles don't override the method and are therefore allowed inside the storage sac.

commented

Bundles are a special case - you can put a bundle inside a bundle but it will take up the space of the bundle's state rather than allowing stacking as many as you like inside it.
Storage sacs do not follow this mechanic and so allowing one to put bundles inside storage sacs does not make sense.