Attack reach attribute will cancel range enhancements from other mods
Jackiecrazy opened this issue ยท 1 comments
Please complete the following information:
- Forge-Version: 36.1.31
- Mod-Version: 1.0.0-beta-4b
Describe the bug
Upon installing the mod, due to the addition of a custom attack reach attribute that cancels all attacks beyond said range, other mods can no longer cause your attack reach to extend beyond 3. This is observable with project: war dance and any manner of increasing forge's reach attribute, as I allow for longer attack reach with the forge reach attribute. In the same vein, as PlayerEntity#getDistanceSq()
calculates distance from the center of the mob, the actual reach of the player decreases slightly upon installing this mod depending on the target attacked, and it becomes impossible to attack certain very large mobs, such as the arisaur from Lycanites' Mobs. This can be easily verified by installing nothing but Lycanites and attacking an arisaur in survival, then adding Biomancy and attempting to attack an arisaur in survival.
Expected behavior
The attack reach attribute should not constrain the attack reaches of other mods or the vanilla attack reach.
Additional context
I see the intent is to constrain the attack reach of the Hirudinean Claw. This can be performed strictly on the client side, albeit inelegantly, with some event handlers. I have done so here in order to reduce the base attack reach of fists to 2. It is probably easier to do this with a mixin, but they also pose inherent compatibility risks and I haven't had the need to investigate this particular case. An alternative is to cancel attacks only if attack reach is less than 3, although this still subjects the Hirudinean Claw to a shorter range than what would be expected. Perhaps this can be modified to be of use?
pseudo "fixed" by moving responsibility to https://github.com/Elenterius/Combat-Commons