Blood Magic

Blood Magic

90M Downloads

Sigil of Magnetism A.o.E. is incorrect

tonby opened this issue ยท 6 comments

commented

Issue Description:

Sigil of Magnetism picks up only drop items at south-east area

What happens:

When enabling Sigil of Magnetism, the player picks up some dropped items. However, Only items dropped within the square area in south-east from player are retrieved. Other directions not work. Like this:
https://imgur.com/a/UEhQgey
https://imgur.com/a/UJtTxSt
https://imgur.com/a/6MurvI5

What you expected to happen:

The player picks up all items around him regardless of direction.

Steps to reproduce:

  1. Drop items around the player in any direction
  2. Charge some LP using Blood Orb
  3. Enable Sigil of Magnetism by Shift-right click

Affected Versions (Do not use "latest"):

  • BloodMagic: BloodMagic-1.12.2-2.2.12-97
  • Minecraft: 1.12.2
  • Forge: forge-14.23.3.2698
commented

can we get that last image with the debug screen as well?

commented

The player didn't rotate, so upper is north.
I deleted the test profile of Twitch App for the smallest-structured environment, so I'll remake the profile and take the screenshot.

commented

The screenshot of the reproduced situation is here: https://imgur.com/a/OCkRXhl

commented

Found the issue. For these lines you want grow not expand

commented

expand(double, double, double) and contract(double, double, double) only increase and decrease the max values, respectively. They don't touch the min values. grow(double, double, double) and shrink(double, double, double) on the other hand, change both the min and max values to increase or decrease the size respectively.

commented

PR in progress.