Chat messages contain invalid formatting
DaedalusGame opened this issue ยท 1 comments
Issue Description:
Chat messages contain %d, this is wrong as the only supported formatting for text components is %% and %s. Why did nobody ever notice? Because Mojang actually strips out %d and %f at the lang file parsing level, which also generates wrong behavior. Specifically, it will replace any occurence of %d and %f with %$1s (first parameter as string), so lang file entries containing two %d will just format the first argument twice.
What happens:
Currently, everything works fine, but if another mod were to AT the pattern they use to strip %d and %f...
tooltip.bloodmagic.sigil.divination.currentEssence
will be displayed instead of the actual string.
What you expected to happen:
etc
Steps to reproduce:
- Use Access Transformers to replace the pattern in
net.minecraft.client.resources.Locale
with something more reasonable
...
alternatively
- Install Embers Rekindled
...
Affected Versions:
- BloodMagic: since >3 years ago
- Minecraft: etc
- Forge: etc