Blood Magic

Blood Magic

Mods
94M Downloads

Sacrificial Dagger bypasses Death Save mechanisms

qrss opened this issue ยท 3 comments

commented

Issue Description:

Grim Reaper's Sprint on Living Armor does not save you from killing yourself with a Sacrificial Dagger.
This behavior of the Sacrificial Dagger might be causing more serious issues with Death Save mechanisms from other mods: TeamTwilight/twilightforest#625

What happens:

Grim Reaper's Sprint triggers, but you still die.

What you expected to happen:

Grim Reaper's Sprint saves you.

Steps to reproduce:

  1. Wear Living Armor with the Grim Reaper's Sprint upgrade.
  2. Kill yourself with a Sacrificial Dagger.

Affected Versions:

  • BloodMagic: 2.3.3-101
  • Minecraft: 1.12.2
  • Forge: 14.23.4.2760
commented

Update. Enhancement/Suggestion. Bug label?

commented

On Twilight Forest's issue tracker it was suggested that replacing the code

player.onDeath(DamageSourceBloodMagic.INSTANCE);
player.setHealth(0);

with

player.setHealth(0);
player.onDeath(DamageSourceBloodMagic.INSTANCE);

in the function onItemRightClick in the source file ItemSacrificialDagger.java (lines 101 and 102) might solve this problem.

commented

Similar issue with Thaumcraft's Charm of Undying
AllTheMods/ATM3-Remix#79