Blood Magic

Blood Magic

90M Downloads

Sacrificial Dagger gives free LP when Glass Hearts is installed

Scorch-Mechanic opened this issue · 2 comments

commented

Issue Description:

Sacrificial Dagger use, both ordinary right clicking and use with incense (and blood orb right clicking) fail to properly reduce player health when the Glass Hearts mod is installed. Sound effects play, camera flinches, healthbar flashes, and the blood altar gains LP, but no health is actually removed. Curiously, trying to overdraw from a personal network properly reduces health (tested with lava sigil and blood lamp sigil).

What happens:

Rightclick with sacrificial dagger (or blood orb), LP is added to blood altar (or personal network), but no health is removed. Free LP.

What you expected to happen:

Obviously, that I should pay with hearts for this LP.

Steps to reproduce:

Add Glass Hearts to your modlist and attempt to use a sacrificial dagger or blood orb on yourself.

Other thoughts:

Glass Hearts replaces the vanilla health system with itself so that it can render extremely small fractions of a heart. At the bottom of the "mod showcase", the author says that because it replaces vanilla, "sethealth" won't work. Is that possibly the cause of this bug? I'm not a coder, just a layperson, so please pardon my ignorance.

I've already submitted an issue on the Glass Hearts github page, but the mod is currently in need of a maintainer so I doubt it'll be fixed over there.


Literally everything in my test-instance:
Minecraft 1.12.2
Minecraft Coder Pack 9.42
Forge Mod Loader 8.0.99.99
Minecraft Forge: 14.23.5.2815
BloodMagic 1.12.2-2.4.0-102
Glass Hearts 1.12.1-1.0.66
Just Enough Items 4.15.0.268
Guide-API 1.12-2.1.8-63

commented

Does it affect the Blood Orbs as well? They don't use setHealth().
Eh. Nevermind. GlassHearts author should fix this.

commented