Performance issues sigils
runescapejon opened this issue · 11 comments
Issue Description:
Hello so, i have ran into an issue regarding of the sigils one of my one of players as using compression sigil to auto-compress stuff and this create performance issue. Here is a screenshot of the issue
What happens:
Performance issues from Compression sigils
What you expected to happen:
some sort of fixed for this minor issue .-.
Steps to reproduce:
...
Affected Versions (Do not use "latest"):
- BloodMagic: 1.12.2-2.4.0-102
- Minecraft: 1.12.2
- Forge: 14.23.5.2814
Any specifics on how much the player was compressing? It shouldn't be more inefficient than just crafting all of that manually, just in a shorter timeframe.
it was actually 1 player that was doing it and he had mention that he was compressing a full inventory of items that about it
Consider me interested. Throw anything that you think could or should be optimized at me.
I meant that if you find other things that consume a lot of tick time, I'd like to see it.
I'd also like to see how that graphic looks like once a new build has been released.
I commented this on the PR, but the new improvements take my timings from about 15ms on average (15,000μs) down to 70μs on average.
@runescapejon new version with a fix is available, I would like to see the graph again, if you don't mind
@runescapejon what's the monitoring tool you're using for this called?
https://github.com/lucko/spark I use this but it's base on WarmRoast.