Crash when PneumaticCraft Smart Chest attempts to push into Blood Altar
MuteTiefling opened this issue · 4 comments
Issue Description:
Out of Bounds crash. Logs below.
What happens:
Crash when PneumaticCraft Smart Chest attempts to push into Blood Altar
What you expected to happen:
Nothing, there's already an item in the altar, so it shouldn't do anything.
Steps to reproduce:
- Place Stone in Blood Altar
- Place Smart Chest next to altar
- Place items in the Chest
- Set the Chest to push into the altar (this happens naturally as you're attempting to toggle to pull mode)
Affected Versions (Do not use "latest"):
- BloodMagic: BloodMagic-1.16.4-3.1.2-17
- Minecraft: 1.16.5
- Forge: 36.2.2
- PneumaticCraft: pneumaticcraft-repressurized-1.16.5-2.14.1-245
Logs:
latest.log
Not really sure if this is on BM or PNC side. Reporting to both.
From a cursory examination, it seems that PneumaticCraft is trying to pull from slot 7 of the Blood Altar; which is concerning, since there is only one slot for the Altar. I'd assume it's a PneumaticCraft issue, but it seems like that'd be a weird check to miss...
Yep, it's most likely a logic error on the PNC side. My theory is that I've cached a slot index which then went invalid (e.g. used to be a chest, but it got replaced with a Blood Altar, or something like that). The Smart Chest keeps track of the last slot of the neighbour item handler it interacted with, to reduce inventory scanning.
You're probably safe to close this, I don't think BM is doing anything wrong here.