Blood Magic

Blood Magic

Mods
90M Downloads

Damage bonuses remove potential LP from Dagger of Sacrifice.

Rodg88 opened this issue ยท 1 comments

commented

Issue Description:

Repost of this EnigmaticaModpacks/Enigmatica6#4186

Attack damage buffs, such as strength potions, the Artifacts Power Glove, the Apotheosis shield suffix, some trinkets, or the nutrition dietary effects bonus, all get applied when using the BM Dagger of Sacrifice, before it's LP calculation, thus reducing the effective hearts the target has, and reducing the LP gained.

What happens:

For example, in a test world, a villager gives 1900LP. But in my main world with all my normal equipment on, a villager will give me only about 680LP. If I remove my equipped power glove, shield, and damage trinkets, it goes up to 1700LP. I can't just disable my nutrition bonus, but that's giving +2 attack damage, which explains the last 200 missing LP.

What you expected to happen:

Since the Dagger of Sacrifice ignores health, having extra damage buffs shouldn't affect it.

Steps to reproduce:

  1. Sacrifice a villager, to see how much base LP you get.
  2. Drink a Strength potion.
  3. Sacrifice another villager, you should get LP equal to the original value minus the LP-per-HP * damage bonus

Affected Versions (Do not use "latest"):

  • BloodMagic: 3.1.7-27
  • Minecraft: 1.16.5
  • Forge: 36.2.22
commented

Seems like villagers giving 1900 is probably due to the single attack with the dagger taking off 1HP too