Blood Magic

Blood Magic

Mods
90M Downloads

[Bug] Passive Mobs Give Too Much Blood

CFlatFlat opened this issue ยท 6 comments

commented

Issue Description:

Despite the guide book saying passive mobs give 200 life essence each when sacrificed, they actually give 1,000, making them twice as effective as hostile mobs.

What happens:

After sacrificing a cow or pig, the amount of life essence goes up by about 1,000.

What you expected to happen:

The blood altar's LE should go up by just 200.

Steps to reproduce:

  1. Build a blood altar with no upgrades (mine was Tier II)
  2. Check the LE with a divination sigil (if there is any already inside)
  3. Use the dagger of sacrifice to slay a cow or a pig near the altar
  4. Use the divination sigil again to see how much it went up.

Affected Versions:

  • BloodMagic: 3.1.7-27
  • Minecraft: 1.16.5
  • Forge: 36.2.22
commented

Can you please provide a copy of your BloodMagic config?

commented

The default config gives passive mobs 100 LP per half heart. So if anything the guide may be wrong. Will look at the guide.

commented

As far as I can see, the guide refers to the config. The ValueManager says that LP multiplier is 25 per HP.
https://github.com/WayofTime/BloodMagic/blob/1.16.3/src/main/java/wayoftime/bloodmagic/common/item/ItemDaggerOfSacrifice.java#L50
^- However, default value here would be overwritten by config, of course. And this value can be outdated as well

https://github.com/WayofTime/BloodMagic/blob/1.16.3/src/main/java/wayoftime/bloodmagic/api/IBloodMagicValueManager.java#L16-L23
^- Likewise, this comment might be outdated

BloodMagic/src/main/resources/data/bloodmagic/patchouli_books/guide/en_us/entries/altar/blood_altar.json

Line 68 in 9e9dde5

"text": "Now that you have a Tier 2 Altar, you can look into getting $(blood)Life Essence$() from somewhere other than yourself. The $(item)Dagger of Sacrifice$() will allow you to sacrifice any mob (monster or passive) that stands within 2 blocks of your Altar, instantly killing them and granting you a decent sum of $(blood)LP$(). You can increase the amount you get per kill with $(l:bloodmagic:altar/blood_rune/sacrifice_rune)Runes of Sacrifice$(). Different entities give different amounts of $(blood)LP$(). Check your configs for more info."

^- refers to the config

commented

The guidebook doesn't seem to mention any values, so now I'm confused as to why I thought passive mobs were supposed to give 200 LP.

commented

Updated to the latest version and regenerated the config, still happens.

Edit: Nvm I didn't pay enough attention.

BloodMagic_Configs.zip

commented

According to the config defaults, it should be 1000 LP. The set modifier is 100 * HP and a Cow/Pig has 10 HP (5 hearts).

The part of the guide book I cited refers to the config, so I don't see where it might be wrong. I'll check ingame when I have the time.