Blood Magic

Blood Magic

Mods
90M Downloads

[1.18] Mystical Agriculture integration failing

Chaos02 opened this issue ยท 2 comments

commented

Issue Description:

Am Modpack author. Log says Mystical agriculture integration fails.

[Worker-Main-5/ERROR] [bloodmagic/]: MysticalAgriculture integration cancelled: unable to find a class: com.blakebr0.mysticalagriculture.api.crop.ICrop
  • BloodMagic: 1.18.2-3.2.5-40
  • Minecraft: 1.18.2
  • Forge: forge-40.1.73
commented

Thanks, will look at the changes to their methods later.

commented

I noticed that "1.18 and older is NO LONGER SUPPORTED" but then breaking API changes were made in the 1.18 branch..

This MysticalAgriculture commit b77e79cb138e9b8461c33b9489b3539a36aeb516 removed the interface ICrop.

Removing an interface is a little bit crappy to do in an "api" package. But it was marked:

// TODO: 1.17: remove
@Deprecated

BloodMagic/src/main/java/wayoftime/bloodmagic/ritual/harvest/HarvestHandlerPlantable.java

Line 175 in 69b6270

Class<?> mysticalCrop = Class.forName("com.blakebr0.mysticalagriculture.api.crop.ICrop");

Now you just use the Crop class directly. And I don't know if it matters here but getCrop returns a net.minecraft.world.level.block.CropBlock, not a net.minecraft.block.CropsBlock (class renamed from 1.16 -> 1.18).