Blood Magic

Blood Magic

90M Downloads

Ritual of The Ballad of Alchemy stacks items with different NBT data

SoulSkin opened this issue ยท 4 comments

commented

When creating things with the Ritual of The Ballad of Alchemy, The ritual will move items from an input chest to the alchemy set without respecting the NBT data on the items. For example, when creating alchemy items and the alchemy set has one of each required item, adding an item of the same type and one in the alchemy set, but with different NBT data(named), it ignores the NBT data and stacks the named item with the normal item. (used version 1.0.0g with forge 1.7.2-10.12.2.1124)
alchemy set with base ingrediants
chest filled with required items with NBT data
alchemy set after NBT items added (by hopper)

commented

After doing some more testing, the ritual seems to always remove NBT data, no matter what is already in the alchemy set.

commented

Found the problem in code. It doesn't check the NBT ever. Working on a PR

commented

Working individually on this. I'll close the issue when one of us finishes :P

commented

Go right ahead. btw, you might also want to make the output slot of the alchemy set so it can't have items put into it. If there is an item that stacks and has NBT data in the output chest and you put the same item (w/o NBT) in the output of the ritual, you get a stack of items with the NBT data (may have used this in Agrarian Skies with the books with enchantments given in reward bags to dupe them... xD)