Sigil of Suppression turns flowing fluid blocks into source blocks
Croebh opened this issue ยท 5 comments
Issue Description:
Sigil of Suppression turns flowing fluid blocks into source blocks. Works as intended for Lava and Water.
What happens:
When there is flowing Life Essence in the world, such as in a blood fountain, and you go near it with an activated Sigil of Suppression, when the flowing essence returns, it comes back as a source block. Leaving and returning multiple times duplicates it further, causing more and more source blocks to be created.
What you expected to happen:
Flowing blocks to return as flowing blocks, not source blocks
Steps to reproduce:
- Place Life Essence, or other non-vanilla fluid source block, creating flowing blocks around it
- Activate Sigil of Suppression, and go near the fluid, causing them to be 'suppressed'
- Leave the area or deactivate the Sigil
- Previously flowing blocks are now source blocks, expanding, and therefore duplicating, the fluid. Repeated uses duplicate the effects
Affected Versions (Do not use "latest"):
- BloodMagic: 1.8.9-2.0.0-20
- Minecraft: 1.8.9
- Forge: 11.15.1.1765
Tested with, and without the following mods, just for the additional fluids for testing.
- Tinkers 1.8.9-2.2.0b
- PneumaticCraft - 1.89-1.13.8-12
Hmm...it looks like I'm splitting the block's state into name and meta...and then returning it as a state, but I can't store IBlockState as NBT...I can dig around once I have enough time, unless someone wants to do it first.
Why were you doing them as name and meta, and not simply as an ItemStack? I'll poke this tonight if I can, but the fix won't be in 1.8.9 since it is EOL - it will be fixed in 1.9 though.
Forge has fixed this with MinecraftForge/MinecraftForge@7c4ffde
Will re-implement the removed features in afa6ccd.
