Blood Magic

Blood Magic

Mods
90M Downloads

Sacrificial dagger kills bosses

TeamDman opened this issue ยท 0 comments

commented

https://github.com/WayofTime/BloodMagic/blob/12f3d5c6e005295e2e78c67e9ef2c2929526524b/src/main/java/WayofTime/bloodmagic/item/ItemDaggerOfSacrifice.java

Issue Description:

No checks to make sure the sacrifical dagger target isnt a boss.

What happens:

Bosses die to the sacrifical dagger

What you expected to happen:

Bosses should not be able to be sacrificed to the dagger, alternatively give them more than 500lp

Steps to reproduce:

  1. place alter beside wither
  2. kill wither with sacrifical dagger
  3. ez nether star?
    ...

Affected Versions (Do not use "latest"):

  • BloodMagic: BloodMagic:1.9.4-2.0.4-58
  • Minecraft: 1.10.2
  • Forge: 1.10.2-12.18.1.2088

1.7.10 implementation was approx. :

if (entity instanceof IHoardDemon || entity instanceof EntityWither || entity instanceof EntityDragon || entity instanceof EntityPlayer || entity instanceof IBossDisplayData || entity.isDead || entity.getHealth() < 0.5f) return;