Blood Magic

Blood Magic

90M Downloads

Living Armor Stats Sticking with player

Shadow3641 opened this issue ยท 19 comments

commented

Issue Description:

After upgrading my living armor and using all 300 points i tried to reset it with the ritual Sound of the Cleansing Soul. I got all the upgrade tomes like i was supposed too but if you looked at the tool tip of the chestplate it would show that i still had all of my stats

What happens:

This picture was after i did the ritual Sound of the Cleansing Soul and i also tryed to put the quick feet and strong legs upgrade on.

2016-10-03_20 17 54

if you take it off and take a look at the tool tip it displays correctly

2016-10-03_20 18 00

to fix this i tried putting all my items in a chest and deleting player data with the same result happening. I have also tried to delete the old armor and make new armor and that seemed to work but, now I'm stuck with armor that will not upgrade i tried to test this by performing the Ritual of Living Evolution. Yet again when its not on my chest it looks like it worked.

2016-10-03_20 53 11

But when i put it back on

2016-10-03_20 52 39

It goes back to having no upgrades.

What you expected to happen:

tool tips and stats to update with with the armor

Steps to reproduce:

  1. Get some living armor
  2. Upgrade it
  3. Try and wipe it clean with the Ritual Sound of the Cleansing Soul
    ...

Affected Versions (Do not use "latest"):

  • BloodMagic: 1.9.4-2.1.0-65
  • Minecraft: 1.10.2
  • Forge: 1.10.2-12.18.1.2095
commented

Does this happen in SSP (Or SMP if this is SSP)?

commented

SMP I tested this in SSP and could not duplicate it

commented

Gotta love SMP only issues~
I'll take a look at this today.

commented

Thanks Way!

commented

Ok, so through some experimentation, it seems that the issue is not that the armour can't be trained, it just seems that it does not refresh the upgrades that the person has only when it is equipped. Through my testing, the armour can still be trained, and any upgrades that are removed are in fact removed. It is verifiable if you use the Quick Feet upgrade.

I'll post more once it is found.

commented

I also am experiencing this in SMP.

commented

Saw this still open and thought I'd throw in the results of my testing just in case you'd like it. The armor tool tip, when it's equipped, seems to be locked in whatever state it was in when the client first encounters it . Disconnecting and reconnecting does not fix the issue, only a client restart does. After restarting the client, loading into the server will load the current state of the armor as the new "locked" state. This seems like the client is loading information client side about living armor that overwrites what the server is trying to tell it.

Some other interesting interactions are occasionally the tool tip rapidly flickers between the locked state and the true state of the armor (semi-rare, no reproduction steps). And after connecting into a server while having an out of date locked state, but before the server finishes loading in all the player information, living armor in the inventory shows the "locked" state stats, then updates to the current server state once the data finishes loading.

This information comes from the FTB infinity lite pack 1.1.0, running on a locally hosted server.

commented

To add to the above, I've done most of the same testing and an oddity is that while most things reflect the true state jump height retrains the 'locked' state. If the MC client is what handles jump height then it's a simple consequence of the locked bug, if not there might be another thing to check in to.

Direwolf20 1.0.0 for 1.10.2 on a non-local server.

commented

I experienced the same thing on a Direwolf20 1.10 server, the only notable difference I had was that even after doing the ritual to remove the upgrades I was still receiving the buffs from them. I still had the extra hearts from the Healthy upgrade and still had the jump height from Strong Legs, etc. I did notice that after the server was restarted the tooltip had been updated and the buffs were gone.

commented

Will be fixed whenever I get around to rewriting living armor.

commented

Are there any updates related to this issue by chance? I've just encountered this bug on a SevTech server and I thought I would throw in my experience with this.
I have a set of Living Armour that I got a bunch of upgrades on over time. I read up on the Armour a little and thought I would clear the current upgrades with the Sound of the Cleansing Soul ritual and increase the Upgrade Points cap with the Ritual of Living Evolution so that I could start training some specific upgrades that I wanted to have on the armour. Right after I used the Sound of the Cleansing Soul I noticed the Armour still had all of its upgrades on it, I tried to use the ritual again but it didn't do anything the second time. I ran around a bit and found that some of the upgrades still worked, I ran faster and I jumped higher but I didn't get a health boost or attack boost like I did before the ritual. I thought this was some inventory desync so I relogged but the armour still had all of the same upgrades listed in the tooltip. When I dropped the armour and picked it back up the tooltip seemed to be showing the right Upgrade Point cap and some new upgrades but when I tried to put the armour on it changed right back to the same exact state it was in before I used the Sound of the Cleansing Soul.
This is on a SevTech server running pack version 3.0.6 which has BM version 1.12.2-2.2.7-90

commented

Is there a workaround for this? The bug seems to be present in 1.11.2 still, and this seems to be quite an old issue ๐Ÿ˜ข
Restarting the server did not actually update the text.

EDIT: I can take off the armor and view the upgrades in my inventory. So, that works for me for now ๐Ÿ˜„

  • I haven't gotten to the point of removing upgrades yet though.
commented

I'm rewriting the Living Armor impl for 1.12. Not much I can do for the current impl

commented

@TehNut So no fix for 1.11.2? ๐Ÿ˜ข
That sucks. ๐Ÿ˜„

commented

Is there a workaround for this at the moment? Besides waiting until the server restarts. Oops it doesn't help.

commented

Relogging should do it most of the times.

commented

I tried but it doesn't help. I'm using v1.12.2-2.3.3-101

commented

Are you talking about the stat flickering or not having the stats that you should?
The first one cannot really be fixed until you're capped out, the second should be fixed by unequipping and relogging or restarting the client.

If that doesn't work you'll have to wait for a fix.

commented

Ahh thanks for your help. Restarting the client does fix the stat.