Chisel

Chisel

150M Downloads

Deprecated version of getDrops overridden

SquidDev opened this issue ยท 1 comments

commented

The 1.11/1.12 blocks override the List<ItemStack> getDrops(IBlockAccess world, BlockPos pos, IBlockState state, int fortune) method:

public List<ItemStack> getDrops(IBlockAccess world, BlockPos pos, IBlockState state, int fortune) {

However, this overload is deprecated, one should instead override public void getDrops(NonNullList<ItemStack> drops, IBlockAccess world, BlockPos pos, IBlockState state, int fortune). This makes it consistent with vanilla blocks such as BlockLeaves.

I realise this is a rather petty issue (sorry), but some mods (well, ComputerCraft) calls the latter method, meaning you don't always get the correct block when breaking with a turtle.

commented

Thanks!