Combat Enchantments[Fabric]

Combat Enchantments[Fabric]

266k Downloads

Bug report: Incompatibility with Spectrum 1.8.0 because of @Override use

DaFuqs opened this issue ยท 1 comments

commented

Describe the bug
Combat Enchantments uses an Override in CenchantsLivingEntityMixin, causing it's transformation to conflict with everything else that touches this piece of code.
In this case Spectrum tries to do a WrapWithOperation on this method to do something similar, but since the method got overridden, the game crashes.

This piece of code exists for 1.20.1, as well as the current 1.21 branch of Combat Enchantments.

Switching the Override to an inject, WrapWithOperation or similar would fix that incompatibility.

Error messages

InvalidInjectionException: At("INVOKE") on net/minecraft/class_1309::spectrum$preventStatusClear with priority 1000 cannot inject into net/minecraft/class_1309::method_6012()Z merged by com.dsfhdshdjtsb.CombatEnchants.mixin.CenchantsLivingEntityMixin with priority 1000 [INJECT_PREPARE Applicator Phase -> spectrum.mixins.json:compat.quilt_status_effect.absent.LivingEntityPreventStatusClearMixin from mod spectrum

To Reproduce

  1. Build pack with Combat Enchantments & Spectrum
  2. Startup the game
  3. ???
  4. No profit

Additional context
The original issue on Spectrum's side: DaFuqs/Spectrum#584
It also features the full startup crash log, including exact mod versions.