
(Bug) Adding Sharpness to weapons doesn't really change the displayed old blue tooltip
DanielMC101 opened this issue ยท 4 comments
Ah yeah, I forgot the weird quirks of the vanilla tooltip... If an item has specific default modifiers (with specific UUIDs/IDs as of 1.21) for damage and attack speed, then those will show up in green and include the base damage as well as enchantment damage (in theory). If the modifiers don't match that condition, the game will instead use the blue tooltip, which only shows the additional damage over base damage and does not include enchantment modifiers (for whatever reason). My mod currently basically just tells the client to switch to the second "kind" of tooltip, which I forgot doesn't include the enchantment modifiers. I will fix that soon.
Curiously, as of 1.21, this is broken with the default green tooltips as well (see MC-271840), so for the 1.21 version, I'll add an option to fix that as well.
Ok, so after looking into it, I've decided not to fix this bug in 1.21, as that version introduced datapack-customizable enchantments which makes this much more difficult than expected (and is probably the reason why it doesn't with the vanilla tooltip in 1.21 in the first place). I will release a fix for 1.20.6 though.
@rizecookey yeah, i've recently just realized this is a vanilla bug
This is now fixed in 2.0.4.1 for 1.20.6, I'll wait for a fix in vanilla before I fix it in CombatEdit for 1.21.1.