Compact Machines

Compact Machines

65M Downloads

Use custom namespace for Brigadier arguments

unilock opened this issue ยท 2 comments

commented

I am not using performance mods.

  • Confirm

Description

(copied from AlphaMode#4 - I realize this isn't really applicable to the Forge version of the mod, but I was told this needs to be fixed upstream rather than on the Fabric port specifically)

(this is also mostly copied from Up-Mods/Arcanus-Legacy#60, as I don't know enough to completely understand the issue here)

Lines 61 + 62 of CompactMachines.java register your argument types room_pos and upgrade_type in the minecraft: namespace.
They should be registered in your own compactmachines: namespace instead. (i.e. compactmachines:room_pos and compactmachines:upgrade_type)
Using the reserved namespace (minecraft: or brigadier:) renders the mod incompatible with proxies running on top of Fabric servers, e.g. Velocity. (likely Forge servers as well, though I can't test due to Velocity not supporting Forge versions beyond those for 1.12.2)

Related issue: PaperMC/Velocity#789

Mod Version

4.5.0a

Fabric Version

Minecraft 1.18.2 - Fabric 0.14.9

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

commented

Looks like this has been fixed with 2098c14 and merged downstream. Closing untested under the assumption that it works. (too lazy to test right now, but I don't see why it wouldn't)