Describe the bug you're experiencing

On Minecraft Forge 1.20.1 (specifically the ATM9 modpack) I noticed a behavior where client sync packets were being queued up for a fake player but never "sent" and the queue was never cleared. This leads to a slow but noticeable memory leak where after around 8 hours there are gigabytes of packets stuck in RAM unable to be cleared and the server eventually crashes with an OOM error.

Removing Connectivity seems to resolve this memory leak.

Reproducability

Unsure how exactly we triggered the bug. The modpack worked fine for about a month and then suddenly we started getting crashes. Analyzing a heap dump of memory showed 8 million instances of ItemStack queued by Sophisticated Storage to be sent to a Fake Player.

Mod up to date

• Before submitting this issue I updated to the newest version and reproduced it

Minecraft version

1.20.1

Modloader version

Forge

Logs

No related output.

Yeah, so turns out this may just be a forge bug that Connectivity was making worse. It looked at the time like the bug was resolved after removing Connectivity, but the time to fill up RAM just went from around 6 hours to fill to around 16 hours to fill. Sorry for the bug report!

that sounds quite odd, connectivity does not have any kind of packet queing, nor fakeplayer related implementations. Fakeplayers to begin with should never get packets que'd up at all, if it does someone implemented a pretty bad fakeplayer.
Forge's fakeplayer connection drops all packets and never ques them anywhere, thats still the case with connectivity.
Either this is some weird threee way mod incompat with stuff like krypton, or its just correlation not causation