Create: Steam 'n' Rails

Create: Steam 'n' Rails

Mods
20M Downloads

ConductorCapItem returns null as its repair ingredient

MartinTheDragon opened this issue ยท 3 comments

commented

Describe the Bug

Instead of Ingredient.EMPTY, null is being returned, which can lead to issues like MartinTheDragon/Nuclear-Tech-Mod-Remake#66. To summarize, other mods might depend on the repair ingredient in certain ways, and returning null will lead to a null pointer exception.

Reproduction Steps

Refer to MartinTheDragon/Nuclear-Tech-Mod-Remake#66.
Hovering over a conductor cap in the inventory will also cause this.

Expected Result

No null pointers being returned if constant values such as Ingredient.EMPTY exist.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

EndeavourOS, based on Arch Linux

Mod Version

1.4.4

Create Mod Version

0.5.1c

Minecraft Version

1.18.2

ModLoader and Version

Forge 40.2.10

Other Mods

Nuclear Tech Mod Remake for 1.18

Additional Context

No response

commented

I'll have to check however I think ingredient is annotated with @nullable

commented

Alright I've checked and this is 100% our fault I'll patch it up and release a new version hopefully today

commented

Fixed in b30b1f8