Dropt

Dropt

Mods
3M Downloads

Harvester blacklist on held item both matches and does not match.

therealpygon opened this issue ยท 2 comments

commented

I think there are a couple logic issues in the HeldItemMatcher checkAsBlacklist() code.

I believe the issues are:

https://github.com/codetaylor/dropt/blob/6c24c93b343d48ea0e84d7b613967170d3c635d3/src/main/java/com/codetaylor/mc/dropt/modules/dropt/rule/match/HeldItemMatcher.java#L243

Should continue if not matched (L251), rather than matched(L243).

https://github.com/codetaylor/dropt/blob/6c24c93b343d48ea0e84d7b613967170d3c635d3/src/main/java/com/codetaylor/mc/dropt/modules/dropt/rule/match/HeldItemMatcher.java#L287

Should return false if not tags because item matched blacklist.

commented

Additional info from Discord:

image

commented

Thanks for the report!

Yeah, there was some junk logic in there. Looks like it was introduced in 1.16.0 with the NBT matching stuff. I'm fairly certain I've fixed it in 1.16.1