Dropt

Dropt

Mods
3M Downloads

Replacing block drops not working well with building gadget

misterplus opened this issue ยท 1 comments

commented

Issue Description

When replacing a block's drop with dropt, then place it in-game with the building gadget, then undo the placement, the new drops will drop and the block goes back to your inventory as well. Resulting in duping.

What Happens

  • Describe what happens
  • Describe, in detail, the steps required to reproduce the issue
    1.Replace a block's drop with dropt
    2.Place a block whose drops have been changed with a building gadget
    3.Undo that placement
    4.Not only you get the block back in your inventory, the newly replaced drops would also drop.

What You Expect to Happen

The block only goes back to your inventory, and does not drop again.

Script

I have two scripts, I thought they should behave the same when used in a undo scenario, but they didn't.
this one works: https://paste.ubuntu.com/p/bBDM4mZKPZ/
this one doesn't work: https://paste.ubuntu.com/p/w47mVFBXY7/
Both script should make the ore drops coal when not using silktouch, but the latter makes undo drop ores when it shouldn't.

I completely understand if you decide not to change this behavior, but it'd be great if you do, the latter script is a lot more straight forward.

Affected Versions

Do not use latest; please supply accurate version numbers.

  • Minecraft:1.12.2
  • Forge: 2847
  • CraftTweaker:
  • Dropt: 1.16.1, should be all the way up to 1.18.0
  • Athenaeum: 1.17.4
commented

Also posted this in the building gadgets issue: Direwolf20-MC/BuildingGadgets#509