Dynamic Surroundings: Fabric Edition

Dynamic Surroundings: Fabric Edition

745k Downloads

[1.20.X] Armor footstep accents with Presence Footsteps?

ArmoredFuzzball opened this issue · 13 comments

commented

With the current Dynamic Surroundings version, if you install Presence Footsteps too, armor rattling noises when walking are gone, even with the footstep accents enabled (I assume because they all get deactivated internally). Presence Footsteps has no such armor noises, so it would be cool if they still worked!

EDIT: Actually, after restarting my game, now Dynamic Surrounding's footstep accents are entirely overriding Presence Footsteps. It would be cool if I could run PF with DS armor noises (and none of the other footstep noises) somehow.

commented

Armor accents should be playing. Only step related sounds affected by presence footstep is watery step, walking on leaves, and moving through brush. The footstep sounds the mod plays is very small and should not be overriding anything presence footsteps is doing.

Which MC version and loader are you using?

commented

Yeah - I don't think I can work around this without making my life complicated or breaking PF. Basically, to suppress the normal footstep sound processing in Minecraft PF will fudge a data value to be artificially large. Because of this, the logic my footstep accent logic taps into will be bypassed.

commented

Sorry I was asleep. I'm using 1.20.2 (technically unsupported I know) with your 1.20.1 version of the mod, with fabric loader version 15.3.
I figured this may be a significant change that isn't worth it, so thanks anyway for looking into it.

commented

Guess I should take this to PF and see if they can make their mod more compatible

commented

You could, but I don't think there is anything they can do. I did the same thing with my footstep sound acoustics way back when. It's a non-complex way to make Minecraft not play footstep sounds for an entity. Modern Minecraft things are more complicated which makes it the best way.

commented

I see, thanks for the info then. Feel free to close this.

commented

I'll leave open for now. Something may occur to me.

commented

I definitely hear the armor accents. They are just replaced with presence footstep's chain footsteps.
PresenceFootsteps-1.9.4+1.20.1.jar (fabric version)
Forge 47.3.5

commented

I was right, since DS uses chainmail equip sounds for the armor footstep accents its completely replaced by PF
image

Not related but why use the equip sounds instead of the armor accents from the forge version? They were perfectly fine.

commented

Well, I'm using Fabric, so I'm not sure about Forge. But I just retested on 1.20.1 and 1.20.4 with loader 16.0, and the issue remains, but maybe I can refine it now.

Presence Footsteps does have armor rattles when walking. They're very subtle, but I can hear them. I don't recall those being there before so maybe that was added between then and now. It does NOT however have chain armor rattles, just iron/gold/diamond/netherite.

If I hit the "disable all sounds" slider in Presence Footsteps, Dynamic Surrounding's armor rattles take over. In my opinion, this mod's rattles are much better, and it also handles chain armor as well.

PF has a setting to turn armor rattles ("Footwear") on and off, but even with it set to off, DS rattles do not work.

So it would be cool if they worked when setting Footwear to off in PF. Maybe this would evade the issue we discussed before with code collision?

commented

You need to disable the PF built in texture pack since it overrides the sounds DS uses for their armor accents. And just a tip if you dont like the sounds being subtle you can adjust the volume in DS's assets and create your own resource pack to override the default settings.

PF can also be customized using resource packs so I managed to do something like this:

Replay.2024-08-02.22-25-38.mp4
commented

You need to disable the PF built in texture pack since it overrides the sounds DS uses for their armor accents. And just a tip if you dont like the sounds being subtle you can adjust the volume in DS's assets and create your own resource pack to override the default settings.

PF can also be customized using resource packs so I managed to do something like this:

Replay.2024-08-02.22-25-38.mp4

Could you explain how to do this? My footstep sound volume is too low I think:(

commented

You need to disable the PF built in texture pack since it overrides the sounds DS uses for their armor accents. And just a tip if you dont like the sounds being subtle you can adjust the volume in DS's assets and create your own resource pack to override the default settings.

PF can also be customized using resource packs so I managed to do something like this:

Replay.2024-08-02.22-25-38.mp4

could you public a instance res_pack?