
Fluid Conduits don't apply colour to the fluids being rendered
buttilda opened this issue ยท 10 comments
@HenryLoenwind A generic fluid added by AOBD.
It uses a default white texture tinted with the colour of the specific metal it represents. You can see the src code for it here
yeah, that would be missing from everywhere we render fluids. I never heard about applying color in addition to the texture for fluids.
Never? That's quite surprising to me XD
It's the standard on how to render a fluid. As you can see by the Tinkers tank in the first picture.
Railcraft, BuildCraft, ThermalExpansion also all apply colours to the fluids they are rendering in their respective tanks.
and the getLocalizedName() is called on the fluid, not a fluidStack...because the filter only stores fluid, not stacks. I need to look into this one deeper.
You should probably store the FluidStack
since NBT data might play a part when filtering fluids
Edit: You could also create a simple dummy FluidStack
so you can call the appropriate getLocalizedName()
I'm pretty sure any fluid with nbt would not be happy in any eio tank or conduit...
We only have fluids, everywhere. when comparing inputs and outputs, in our tanks, ...
Well lucky for you guys NBT data is not often used with FluidStacks
, but in some cases you could probably cause some exploits/loss if you're not storing the NBT data of anything.