Ender IO Zoo

Ender IO Zoo

Mods
962k Downloads

ItemConduitNetwork#inventoryRemoved is not called on chunk unload

Aaron1011 opened this issue ยท 1 comments

commented

Issue Description:

ItemConduitNetwork#inventoryRemoved is normally called when a conduit is removed. However, this method is not called when a chunk containing a conduit is unloaded

What you expected to happen:

The NetworkedInventory remains in the ItemConduitNetwork.inventories list. This memory leak is normally not much of an issue, but can become problematic with mods such as SpongeForge that unload chunks agressively.

Steps to reproduce:

  1. Place down a conduit in a chunk
  2. Observe that ItemConduitNetwork#inventoryAdded is called
  3. Move away, and let the chunk unload
  4. Observe that ItemCondutiNetwork#inventoryRemoved is not called.
    ...

Affected Versions (Do not use "latest"):

  • EnderIO: EnderIO-1.10.2-3.0.1.120_beta
  • EnderCore: EnderCore - 1.10.2-0.4.1.56-beta Download
  • Minecraft: 1.10.2
  • Forge:12.18.1.2092
commented

I think this should do the trick. Can you please retest this when the next build is released? Thank you!