Ender IO Zoo

Ender IO Zoo

962k Downloads

Chickens Lava/Water Egg keeps filling Tanks beyond capacity

tgstyle opened this issue ยท 2 comments

commented

What happens:

Filling a tank with lava/water eggs keeps filling infinitely.

https://minecraft.curseforge.com/projects/chickens/files

What you expected to happen:

Lava/water Eggs to stop filling when the tank is full.

Steps to reproduce:

  1. Build a fluid tank.
  2. Place a lava or water egg in until it fills beyond capacity and keeps going.

Affected Versions (Do not use "latest"):

  • EnderIO: 3.0.1.147
  • EnderCore: 0.4.1.61
  • Minecraft: 1.10.2
  • Forge: 2185

2016-12-27_20 55 45

commented

This is a bug in Chickens.

https://github.com/setycz/ChickensMod/blob/1.10.2/src/main/java/com/setycz/chickens/liquidEgg/LiquidEggFluidWrapper.java#L55

First, they do not respect the "doDrain" flag, destroying the egg also when it's only being asked what it contains. Second, they do not respect the maximum amount they are asked for, returning more then the target tank can take.