[1.10.2] Thermal Expansion Integration Issues
oitsjustjose opened this issue · 7 comments
Issue Description:
When using Thermal Expansion alongside EnderIO & Tinkers' Construct, Thermal Expansion's use of the destabilized redstone texture gets messed up.
It's EnderIO's integration with Tinkers' Construct (confirmed this by removing Tinkers' and keeping EnderIO, and keeping Tinkers' and removing EnderIO - both times reverted this bug).
What happens:
With EnderIO and EnderCore:
As you can see, the texture inside is not even the right texture, and even if it was it is not colorized.
What you expected to happen:
Without EnderIO and EnderCore:
Without Tinkers' Construct:
Like I mentioned, the texture being used is a completely different one (water style instead of lava style), and is properly colored (likely because Tinkers' fluids run heavily on the colorizer where Thermal Expansions aren't post-colorized at all).
Steps to reproduce:
- Install Thermal Expansion 2.0.0.64 with its dependencies
- Install EnderIO
- Install Tinkers' Construct
- Let the installation of both trigger EnderIO's extra fluid initialization
- View energy conduit / energy cell
Affected Versions (Do not use "latest"):
- EnderIO: 3.1.156 through 3.1.172 (did not test earlier versions)
- EnderCore: 0.4.1.64 and 0.4.1.65
- Minecraft: 1.10.2
- Forge: 12.18.3.2239
Your most recent log file where the issue was present:
Copied from latest run in an affected pack
Let me know if I can help with anything else! Fortunately it's not a game-shattering bug :)
Does your logfile have the line "Thermal Foundation fluid 'redstone' is unexpectedly missing. Late registering our own."?
[08:16:48] [Client thread/WARN] [FML]: A mod has attempted to assign Block Block{null} to the Fluid 'redstone' but this Fluid has already been linked to the Block Block{enderio:fluidRedstone}. You may have duplicate Fluid Blocks as a result. It *may* be possible to configure your mods to avoid this.
[08:16:48] [Client thread/WARN] [FML]: A mod has attempted to assign Block Block{null} to the Fluid 'glowstone' but this Fluid has already been linked to the Block Block{enderio:fluidGlowstone}. You may have duplicate Fluid Blocks as a result. It *may* be possible to configure your mods to avoid this.
[08:16:48] [Client thread/WARN] [FML]: A mod has attempted to assign Block Block{null} to the Fluid 'ender' but this Fluid has already been linked to the Block Block{enderio:fluidEnder}. You may have duplicate Fluid Blocks as a result. It *may* be possible to configure your mods to avoid this.
Maybe this?
Ah, totally missed that line, but yeah - I did gather that the problem was partially caused by duplicated registration. I just can't tell (looking at the source code) why the registration is still happening when it should be disabled I would think... at least if the Loader.isModLoaded() check is working.