Ender IO Zoo

Ender IO Zoo

962k Downloads

Farm Station fails to harvest entire mushroom

nrllewellyn opened this issue ยท 7 comments

commented

Issue Description:

In a farming station, if the axe breaks before a large mushroom is entirely harvested, the remaining mushroom is left floating in the air. Because of the way that mushrooms grow (when bone mealed), this will often prevent additional mushrooms from growing. Ultimately this results in the farm stalling and wasting bonemeal.

What happens:

See above.

What you expected to happen:

Farming station should pick up where it left off after replacing axe. Alternatively, farming station could scan for harvestables above ground level (although this could cause unexpected/undesired side effects).

Steps to reproduce:

  1. Set up farming station
  2. Add mushrooms, bonemeal, and wooden axe
  3. Wait for axe to break

Affected Versions (Do not use "latest"):

  • EnderIO: 1.10.2-3.1.173
  • EnderCore: 1.10.2-0.4.1.65-beta
  • Minecraft: 1.10.2
  • Forge: 12.18.3.2239

Your most recent log file where the issue was present:

N/A.

commented

Nope, server owners would be very upset if we'd start scanning the whole area for left-over blocks...

(PS: Note that I'm not closing this yet)

commented

That makes sense. Is it possible for the farming station to store the location of the last block when the tool broke, and then only check the next logical block when the tool is replaced?

commented

Here's a screenshot of what happens, in case you're interested. None of these mushroom blocks are breaking.

2017-03-10_15 58 35

commented

I mean, that's how trees work, more or less, so it should be doable. There must be a bug in the mushroom farmer code.

commented

Thx for noting how the mushroom farmer works, I think changing it to work like the tree farmer (or just sorting the list of blocks to harvest by y-level) may be the easiest thing to do.

Update: What? There is not Mushroom Farmer, this work is done by the Tree Farmer, and it does sort by y-level... I have to look deeper into what happens here.

commented

Ok, I see what's happening. It is harvesting from the top, but after the harvest it tries to replant---and doesn't check if the planting location is free. So it overrides the stem of the big mushroom with a small mushroom.

commented

Notable thing: Farmer should work with mushrooms like it works with trees, e.g. cut from up to down. For now farming station cuts bottom block and replaces it with mushroom, then it cuts all left blocks before axe runs out.