
[1.10.2] All Conduit Facades Invisible In-World with CTM Installed
oitsjustjose opened this issue ยท 7 comments
Issue Description:
Conduit facades painted with any texture (Vanilla, Chisel or any other mod) do not render in-world. Their hit box is still there, so it's not as though the facade thinks I'm holding a facade-hiding item; they simply don't render. I know you just changed this rendering system some for the new CTM library for Chisel, so I tried a few things to help debug and actually found something quite interesting:
The rendering bug only occurs when the CTM is loaded. Not having CTM installed allows the facades to work as expected, but as soon as CTM is installed (like in my test instance with only CTM and EnderIO) all facade rendering goes invisible.
What happens:
Facades are invisible!
What you expected to happen:
Non-invisible facades to be not-invisible!
Steps to reproduce:
- Install EnderIO + EnderCore
- Install CTM (tested with CTM 0.1.0.13)
- Observe invisible, untextured facades in-world!
Affected Versions (Do not use "latest"):
- EnderIO: 3.1.193
- EnderCore: 0.4.1.65
- Minecraft: 1.10.2
- Forge: 12.18.3.2281
Your most recent log file where the issue was present:
No crash.
I traced it out and found that CTM ASMs Ender IO's BlockConduitBundle.canRenderInLayer(BlockRenderLayer) destroying our rendering.
@tterrag1098 That's why LexManos always says that people who do coremods are retards. While I don't agree in general, could you ASM a bit more careful, please?
I fail to feel the joke...it took me nearly 2 hours of single-stepping through the rendering code to find this.
Oh no, I totally understand that. The only thing I found humor in was that you were supporting CTM and CTM was trying to support you, and in the end it just caused more problems!
I can't imagine how irritating it was to sit there and think something is your fault when it's just someone else messing with your code. None of my mods have ever used ASM for pretty much this reason - I've always been afraid of breaking someone else's code with my own.
@oitsjustjose Could you test this build to see if the problem persists? http://ci.tterrag.com/job/ConnectedTexturesMod/branch/1.10%252Fdev/14/